Skip to content

Fix linode_interfaces None issue #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yec-akamai merged 3 commits into from
Nov 21, 2025
Merged

Fix linode_interfaces None issue #729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5680c86
fix image filter
yec-akamai Nov 21, 2025
43a603d
drop none interfaces
yec-akamai Nov 21, 2025
0009fc9
address comments
yec-akamai Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions plugins/modules/instance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1640,8 +1640,11 @@ def _handle_present(self) -> None:
self.results["disks"] = paginated_list_to_json(self._instance.disks)
self.results["networking"] = self._get_networking()

self.results["linode_interfaces"] = paginated_list_to_json(
self._instance.linode_interfaces
instance_linode_interfaces = self._instance.linode_interfaces
self.results["linode_interfaces"] = (
paginated_list_to_json(instance_linode_interfaces)
if instance_linode_interfaces is not None
else instance_linode_interfaces
)

def _handle_absent(self) -> None:
Expand All @@ -1658,8 +1661,11 @@ def _handle_absent(self) -> None:
self.results["disks"] = paginated_list_to_json(self._instance.disks)
self.results["networking"] = self._get_networking()

self.results["linode_interfaces"] = paginated_list_to_json(
self._instance.linode_interfaces
instance_linode_interfaces = self._instance.linode_interfaces
self.results["linode_interfaces"] = (
paginated_list_to_json(instance_linode_interfaces)
if instance_linode_interfaces is not None
else instance_linode_interfaces
)

self.register_action("Deleted instance {0}".format(label))
Expand Down
4 changes: 2 additions & 2 deletions tests/integration/targets/image_list/tasks/main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
- name: List image_list with empty filter
linode.cloud.image_list:
filters:
- name: vendor
values: DefinitelyRealVendor
- name: label
values: DefinitelyRealLabel
register: filter_empty

- name: Assert image_list with empty filter
Expand Down