Skip to content

[deps] bump go to 1.25, bump deps in devbox.lock, move go dev deps into go tools#892

Merged
AshleyDumaine merged 12 commits intomainfrom
go-1.25
Oct 9, 2025
Merged

[deps] bump go to 1.25, bump deps in devbox.lock, move go dev deps into go tools#892
AshleyDumaine merged 12 commits intomainfrom
go-1.25

Conversation

@AshleyDumaine
Copy link
Collaborator

@AshleyDumaine AshleyDumaine commented Oct 7, 2025

What this PR does / why we need it: This PR tackles the go 1.25 upgrade and some tech debt around our tool deps:

  • bumps go to 1.25 in devbox, go.mod, and the docker image
  • bumps the other development-only deps to be compatible with go 1.25
  • moves the development-only deps to be managed by go tools which was added in go 1.24 for this kind of problem.
  • bumps the super-out-of-date devbox.lock
  • fixes go-analyze GHA workflow to run the golangci-lint we specify in our tool deps rather than the GHA action
  • updates go-analyze GHA workflow to run the missing gosec (added to go tools) target as well as the missing vulncheck target
  • addresses minor fixes needed by updating these out-of-date tool deps.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Oct 7, 2025
@AshleyDumaine AshleyDumaine changed the title [deps] bump go to 1.25 [deps] bump go to 1.25, bump deps in devbox.lock, move go dev deps into go tools Oct 7, 2025
@AshleyDumaine AshleyDumaine mentioned this pull request Oct 8, 2025
4 tasks
@codecov
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.94%. Comparing base (d57486e) to head (b3737d2).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...al/controller/linodefirewall_controller_helpers.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #892      +/-   ##
==========================================
- Coverage   65.96%   65.94%   -0.02%     
==========================================
  Files          71       71              
  Lines        7956     7958       +2     
==========================================
  Hits         5248     5248              
- Misses       2406     2408       +2     
  Partials      302      302              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

eljohnson92
eljohnson92 previously approved these changes Oct 9, 2025
@AshleyDumaine AshleyDumaine merged commit fd55b77 into main Oct 9, 2025
15 of 17 checks passed
@AshleyDumaine AshleyDumaine deleted the go-1.25 branch October 9, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants