new: Add support for VM Placement#490
Merged
lgarber-akamai merged 9 commits intolinode:proj/vm-placementfrom Apr 16, 2024
Merged
new: Add support for VM Placement#490lgarber-akamai merged 9 commits intolinode:proj/vm-placementfrom
lgarber-akamai merged 9 commits intolinode:proj/vm-placementfrom
Conversation
lgarber-akamai
commented
Apr 12, 2024
| github.com/jarcoal/httpmock v1.3.1 | ||
| github.com/linode/linodego v1.30.0 | ||
| github.com/linode/linodego/k8s v0.0.0-00010101000000-000000000000 | ||
| github.com/stretchr/testify v1.9.0 |
Contributor
Author
There was a problem hiding this comment.
This was added in the parent/child project branch (which hasn't been merged to main yet)
yec-akamai
approved these changes
Apr 15, 2024
Contributor
yec-akamai
left a comment
There was a problem hiding this comment.
Nice work! All tests passed on my end 🎉
ykim-akamai
approved these changes
Apr 15, 2024
Contributor
ykim-akamai
left a comment
There was a problem hiding this comment.
Looks good, tests pass locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This pull request adds support for the upcoming Placement Groups feature, including the following changes:
New Endpoints:
placement/groupsplacement/groupsplacement/groups/{pg_id}placement/groups/{pg_id}placement/groups/{pg_id}/assignplacement/groups/{pg_id}/unassignplacement/groups/{pg_id}Updated Endpoints:
/linode/instances&/linode/instances/{linode_id}- Updated to include PG info/linode/instances- Updated to accept a PG to assign the Linode to on creation/linode/instances/{linode_id}/migrate- Updated to accept a PG to assign the Linode to on creation/linode/instances/{linode_id}/clone- Updated to accept a PG to assign the Linode to on creation/regions&/regions/{region_id}- Updated to include PG limitsThis pull request also contains the corresponding integration tests and fixtures for these changes.
✔️ How to Test
The following test steps assume you have pulled down this PR locally and have pointed your
LINODE_URLandLINODE_TOKENenvironment variables accordingly.Integration Testing
Manual Testing