CI: replace test execution handler with conditional#502
Merged
ykim-akamai merged 3 commits intolinode:mainfrom May 9, 2024
Merged
Conversation
ykim-akamai
requested review from
jriddle-linode and
zliang-akamai
and removed request for
a team
ykim-akamai
added
the
repo-ci-improvement
ykim-akamai
commented
May 8, 2024
| - name: Add additional information to XML report | ||
| if: github.ref == 'refs/heads/main' && github.event_name == 'push' | ||
| - name: Upload test results to bucket | ||
| if: github.ref == 'refs/heads/main' && github.event_name == 'push' && always() |
Contributor
Author
There was a problem hiding this comment.
The secrets of this repo is only available to main branch, hence above checks are required to get the workflow to pass on open PRs against main
jriddle-linode
approved these changes
May 8, 2024
zliang-akamai
approved these changes
May 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Substitute hacky solution of executing integration tests and uploading test data with a more efficient solution using a conditional statement. This enhancement enables us to directly view test output within its associated step :)
✔️ How to Test
Build on forked - https://github.com/ykim-1/linodego/actions/runs/8993610349
TOD link (test instance) - http://198.19.5.79:7272/builds/663aba524f454e00016b8dbf?team=DX&buildName=linodego%201.33.1&bld_id=663aba524f454e00016b8dbf
📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.