Migrated account to account_logins to request helpers#527
Merged
jriddle-linode merged 2 commits intolinode:mainfrom Jun 21, 2024
Merged
Conversation
ErikZilber
requested review from
ykim-akamai and
zliang-akamai
and removed request for
a team
lgarber-akamai
requested review from
lgarber-akamai
and removed request for
lgarber-akamai
ErikZilber
force-pushed
the
TPT2870_migrate_account_to_account_logins
branch
from
ac0c5c8 to
407dd8c
Compare
zliang-akamai
approved these changes
Jun 21, 2024
Member
zliang-akamai
left a comment
zliang-akamai
left a comment
There was a problem hiding this comment.
Things look much simpler and cleaner now, nice job!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Migrated the following files from directly referencing the Resty client in favor of using the new request helpers:
account.go
account_availability.go
account_betas.go
account_events.go
account_invoices.go
account_logins.go