Migrated nodebalancer_firewalls to object_storage_clusters to request helpers#544
Merged
ezilber-akamai merged 7 commits intolinode:mainfrom Jul 11, 2024
Conversation
ezilber-akamai
requested review from
jriddle-linode and
lgarber-akamai
and removed request for
a team
Contributor
|
@ezilber-akamai Just a heads up, this PR might run into some conflicts with #522 depending on which one is merged first 👀 |
lgarber-akamai
approved these changes
Jul 8, 2024
Contributor
lgarber-akamai
left a comment
lgarber-akamai
left a comment
There was a problem hiding this comment.
Tests are passing on my end, great work!
ykim-akamai
approved these changes
Jul 8, 2024
Contributor
ykim-akamai
left a comment
ykim-akamai
left a comment
There was a problem hiding this comment.
LGTM, tests all pass with new fixtures
lgarber-akamai
approved these changes
Jul 11, 2024
Contributor
lgarber-akamai
left a comment
lgarber-akamai
left a comment
There was a problem hiding this comment.
Looks great and tests seem to be passing, nice work!
ezilber-akamai
deleted the
TPT-2877_nodebalancer_firewalls-object_storage_clusters
branch
jriddle-linode
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Migrated nodebalancer_firewalls to object_storage_clusters to request helpers