Migrated object_storage_keys to profile_logins from resty to request helpers#550
Merged
ezilber-akamai merged 6 commits intolinode:mainfrom Jul 15, 2024
Conversation
ezilber-akamai
requested review from
lgarber-akamai and
zliang-akamai
and removed request for
a team
ezilber-akamai
force-pushed
the
TPT-2878_object_storage_keys-profile_logins
branch
from
0467d64 to
c8727a2
Compare
lgarber-akamai
approved these changes
Jul 15, 2024
Contributor
lgarber-akamai
left a comment
lgarber-akamai
left a comment
There was a problem hiding this comment.
All tests are passing locally, nice work! Glad the Postgres test fixtures finally played nice lol
Member
There was a problem hiding this comment.
Is this intentionally deleted or?
Contributor
Author
There was a problem hiding this comment.
Yes, it was deleted intentionally. I marked the test its associated with to be skipped due to some unexpected API behavior with limited object storage keys.
Essentially, when creating a limited Object Storage key with access to no buckets via the API with an empty bucket_access array in the request, the bucket_access field in the response is expected to be an empty array but is currently null.
jriddle-linode
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Migrated object_storage_keys to profile_logins and reran fixtures