test: Update getRegionsWithCaps function to also accept a list of plans that must be available in the identified region

[ykim-akamai]

📝 Description

A helper function has been updated for the logic to resolve integration test regions that also accepts a list of plans which must be available in the resolved region

Note: the function takes list value of plans as an optional parameter

✔️ How to Test

make testint

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

[lgarber-akamai]

Nice use of closures!

[lgarber-akamai]

optional: We can considerably reduce the number of iterations we need to run by aggregating all availabilities into a map hashing on (region, plan):

regionsAvailabilities, err := client.ListRegionsAvailability(context.Background(), nil)
require.NoError(t, err)

type availKey struct {
	Region string
	Plan   string
}

availMap := make(map[availKey]linodego.RegionAvailability, len(regionsAvailabilities))
for _, avail := range regionsAvailabilities {
	availMap[availKey{Region: avail.Region, Plan: avail.Plan}] = avail
}

// ...

regionHasPlans := func(regionID string) bool {
	for _, plan := range plans {
		if avail, ok := availMap[availKey{Region: regionID, Plan: plan}]; !ok || !avail.Available {
			return false
		}
	}

	return true
}

Since this is just for tests I don't think it's a big deal either way; just thought I'd share another approach 👍

[ykim-akamai]

This is a great suggestion! I didn't think of putting it into a hash map but this will for sure be faster than my previous solution 🚀

[yec-akamai]

Tests works well locally, nice work!

[ykim-akamai]

Still left this check in to avoid any unnecessary map lookups when there are no plans to check.

[lgarber-akamai]

Looks great once fixtures are re-run, nice work!