Implemented doRequest helper method#557
Merged
ezilber-akamai merged 8 commits intolinode:mainfrom Jul 29, 2024
Merged
Conversation
ezilber-akamai
force-pushed
the
TPT-2961-base-request-function
branch
from
6411a65 to
bb759a4
Compare
ezilber-akamai
requested review from
jriddle-linode and
yec-akamai
and removed request for
a team
ezilber-akamai
added
the
improvement
yec-akamai
approved these changes
Jul 24, 2024
Contributor
yec-akamai
left a comment
yec-akamai
left a comment
There was a problem hiding this comment.
Works well locally, nice job! Just a small comment.
ezilber-akamai
force-pushed
the
TPT-2961-base-request-function
branch
6 times, most recently
from
35b1ff6 to
757eec6
Compare
ezilber-akamai
force-pushed
the
TPT-2961-base-request-function
branch
from
757eec6 to
47d0a65
Compare
lgarber-akamai
approved these changes
Jul 29, 2024
Contributor
lgarber-akamai
left a comment
lgarber-akamai
left a comment
There was a problem hiding this comment.
Looks perfect, nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Added a private “doRequest” generic helper that accepts the following parameters:
✔️ How to Test
Pull down this PR locally before running tests.
Unit Tests
make testunit