Added support for Block Storage Encryption#572
Merged
ezilber-akamai merged 5 commits intolinode:mainfrom Oct 15, 2024
Merged
Conversation
ezilber-akamai
requested review from
yec-akamai and
ykim-akamai
and removed request for
a team
ezilber-akamai
added
new-feature
ezilber-akamai
removed
the
do-not-merge
yec-akamai
approved these changes
Oct 11, 2024
Contributor
yec-akamai
left a comment
yec-akamai
left a comment
There was a problem hiding this comment.
Works well on my end! Just a nitpick:
ykim-akamai
approved these changes
Oct 15, 2024
Contributor
ykim-akamai
left a comment
ykim-akamai
left a comment
There was a problem hiding this comment.
LGTM, integration tests all pass locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Added support for Block Storage Encryption across the following endpoints:
POST /volumesGET /volumesGET /volumes/<volume_id>GET /regionsGET /regions/<region_id>GET /linode/instancesGET /linode/instances/<linode_id>GET /account✔️ How to Test
Integration Tests
make ARGS="-run TestRegions_blockStorageEncryption" fixturesmake ARGS="-run TestVolume_Get_withEncryption" fixturesmake ARGS="-run TestVolume_Create_withEncryption" fixturesmake ARGS="-run TestInstance_withBlockStorageEncryption" fixtures