Improve image replication test region; Add LA notice#582
Conversation
yec-akamai
requested review from
lgarber-akamai and
ykim-akamai
and removed request for
a team
| regions, err := client.ListRegions(context.Background(), nil) | ||
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
|
|
||
| regionHasCaps := func(r linodego.Region) bool { | ||
| capsMap := make(map[string]bool) | ||
|
|
||
| for _, c := range r.Capabilities { | ||
| capsMap[strings.ToUpper(c)] = true | ||
| } | ||
|
|
||
| for _, c := range capabilities { | ||
| if _, ok := capsMap[strings.ToUpper(c)]; !ok { | ||
| return false | ||
| } | ||
| } | ||
|
|
||
| return true | ||
| } |
There was a problem hiding this comment.
optional: Would it make sense to call getRegionsWithCaps(...) here and filter down the results below?
There was a problem hiding this comment.
I did try to call getRegionsWithCaps(...) at first but figured out it might be better to have the logic here. Because getRegionsWithCaps(...) only return a list of region's id string, we will have to make extra API calls to get the Region object for obtaining necessary info. It's probably slow down the test.
I'm wondering if it makes sense to move regionHasCaps(...) as an independent function, so that we can call it here without repeating this part of logic. What's your thoughts?
There was a problem hiding this comment.
I think that would be a good idea. Maybe we can move it as a separate helper function in integration_test_suite.go
There was a problem hiding this comment.
@ykim-1 @lgarber-akamai thanks for the comment! Just applied the improvement, could both of you re-approve the PR?
lgarber-akamai
left a comment
lgarber-akamai
left a comment
There was a problem hiding this comment.
Image-related tests are all passing on my end, nice work!
ykim-akamai
left a comment
ykim-akamai
left a comment
There was a problem hiding this comment.
LGTM, tests passed locally with new fixture
lgarber-akamai
left a comment
lgarber-akamai
left a comment
There was a problem hiding this comment.
Looks great, nice work!
3 participants
📝 Description
Improve the image replication test case and remove the hardcoded regions.
Add LA notice to image gen2 endpoint.
✔️ How to Test