Added support for migrations field for Placement Groups#617
Merged
ezilber-akamai merged 4 commits intolinode:mainfrom Nov 18, 2024
Merged
Conversation
ezilber-akamai
requested review from
jriddle-linode and
ykim-akamai
and removed request for
a team
ezilber-akamai
force-pushed
the
TPT-3181-support-pg-migrations-field
branch
from
bd00b0e to
7a2c05b
Compare
ezilber-akamai
added
the
improvement
jriddle-linode
approved these changes
Nov 15, 2024
Collaborator
jriddle-linode
left a comment
jriddle-linode
left a comment
There was a problem hiding this comment.
Looks good, working locally!
ykim-akamai
approved these changes
Nov 18, 2024
Contributor
ykim-akamai
left a comment
ykim-akamai
left a comment
There was a problem hiding this comment.
LGTM, all tests passing locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Added support for
migrationsfield for Placement Groups and added unit and integration tests.✔️ How to Test
make fixtures ARGS="-run TestInstance_MigrateToPG"make testunit