Implement changes for account APIs#715
Merged
zliang-akamai merged 6 commits intolinode:proj/vpc-linodes-enhanced-interfacesfrom Apr 22, 2025
Merged
Conversation
zliang-akamai
requested review from
lgarber-akamai and
ykim-akamai
and removed request for
a team
zliang-akamai
commented
Apr 8, 2025
Contributor
|
Should the account tests move to unit directory? |
zliang-akamai
force-pushed
the
zhiwei/account-api-changes-linodes-interface
branch
from
b39fd40 to
d9ee366
Compare
zliang-akamai
force-pushed
the
zhiwei/account-api-changes-linodes-interface
branch
from
d9ee366 to
730f843
Compare
…nt-api-changes-linodes-interface
lgarber-akamai
approved these changes
Apr 17, 2025
Contributor
lgarber-akamai
left a comment
lgarber-akamai
left a comment
There was a problem hiding this comment.
Looks great, nice work!
…nt-api-changes-linodes-interface
zliang-akamai
merged commit 6fd4b61
into
linode:proj/vpc-linodes-enhanced-interfaces
10 checks passed
rahulait
pushed a commit
to rahulait/linodego
that referenced
this pull request
Jun 27, 2025
* Implement changes for account APIs * Cleanup and re-add tests * gofumpt * Add availability notice
rahulait
pushed a commit
to rahulait/linodego
that referenced
this pull request
Jul 8, 2025
* Implement changes for account APIs * Cleanup and re-add tests * gofumpt * Add availability notice
zliang-akamai
added a commit
that referenced
this pull request
Aug 21, 2025
* Implement changes for account APIs (#715) * Implement changes for account APIs * Cleanup and re-add tests * gofumpt * Add availability notice * Added support for `networking/` and `vpcs/` endpoint changs for VPC Linodes Enhanced Interfaces (#727) * Added support for networking/firewalls related changes * Added support for Networking IPs and VPC changes * Addressed PR comments * Add support for firewall template (#726) * Add firewall template functions * Add integration tests * Fix inline doc * Adding VPC Enhanced Interfaces (#724) ## 📝 Description **What does this PR do and why is this change necessary?** Initial additions for interfaces ## ✔️ How to Test **How do I run the relevant unit/integration tests?** ```bash make test-unit ``` * Linode instance changes for Linode Interfaces (#723) * Add linode instance changes for linode interfaces * Fix interface structs * Add tests * go work sum * Make default firewall IDs pointers (#765) * Add DoublePointer helper function * Remove duplicated DoublePointer in test * Fix * Add DoublePointerNull * lint * Make nullable default firewall IDs pointer * Make default firewall IDs in update options double pointers * Update unit test to utilize DoublePointer helper func * Firewall Related integration tests (#760) * firewall_tests * fix * fix * fix_format * fixPRcomments * fix * Linode Interfaces: Consolidate InterfaceGeneration and LinodeInterfaces fields into InstanceCreateOptions (#759) * Consolidate InterfaceGeneration and LinodeInterfaces fields into InstanceCreateOptions * Add network_helper to create opts * Add unmarshal * Re-run fixtures * Fix various issues * Fix firewall settings tests (#772) * Make interface optional fields pointers (#773) * Fix firewall settings tests * Make optional fields pointers for Linode interface structs * Rename Label field to VLANLabel to align with API attribute naming * golangci-lint run --fix * fix a comment * Nullable default firewall ids (#776) * Make default_firewall_ids nullable * Fix unit test * Add future breaking change notice for ConfigID in VPC IP (#775) * Add future breaking change notice for ConfigID in VPC IP * Update wording * Make FirewallID in linode interface creation options a double ptr (#792) * Make FirewallID in linode interface creation options a double ptr * golangci-lint fmt * Refresh the monthly transfer test fixture * Make `address` of interface ipv4 optional (#804) * Make `address` of interface ipv4 optional * Update test * Add omitempty --------- Co-authored-by: Erik Zilber <ezilber@akamai.com> Co-authored-by: Jacob Riddle <87780794+jriddle-linode@users.noreply.github.com> Co-authored-by: Vinay <143587840+vshanthe@users.noreply.github.com> Co-authored-by: Lena Garber <114949949+lgarber-akamai@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This is to support the account API changes in the VPC Linodes Enhanced Interfaces project.
✔️ How to Test