Update database host fields from "secondary" to "standby"#855
Merged
zliang-akamai merged 4 commits intolinode:mainfrom Dec 8, 2025
Merged
Update database host fields from "secondary" to "standby"#855zliang-akamai merged 4 commits intolinode:mainfrom
zliang-akamai merged 4 commits intolinode:mainfrom
Conversation
zliang-akamai
requested review from
ezilber-akamai and
vshanthe
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates database host field naming from "secondary" to "standby" to align with a DBaaS API change. The changes ensure consistency between the Go SDK struct definition and the API response format.
- Updated the
DatabaseHoststruct field fromSecondarytoStandby - Updated all test fixtures (JSON files) for both PostgreSQL and MySQL databases
- Updated integration test assertions to use the new field name
Reviewed changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| databases.go | Changed struct field from Secondary to Standby in DatabaseHost type |
| test/unit/fixtures/postgresql_databases_list.json | Updated JSON key from "secondary" to "standby" |
| test/unit/fixtures/postgresql_database_update.json | Updated JSON key from "secondary" to "standby" |
| test/unit/fixtures/postgresql_database_get.json | Updated JSON key from "secondary" to "standby" |
| test/unit/fixtures/postgresql_database_create.json | Updated JSON key from "secondary" to "standby" |
| test/unit/fixtures/mysql_databases_list.json | Updated JSON key from "secondary" to "standby" |
| test/unit/fixtures/mysql_database_update.json | Updated JSON key from "secondary" to "standby" |
| test/unit/fixtures/mysql_database_get.json | Updated JSON key from "secondary" to "standby" |
| test/unit/fixtures/mysql_database_create.json | Updated JSON key from "secondary" to "standby" |
| test/integration/postgres_db_config_test.go | Updated assertion from db.Hosts.Secondary to db.Hosts.Standby |
| test/integration/monitor_services_token_creation_test.go | Corrected fixture path reference |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zliang-akamai
commented
Nov 25, 2025
Member
Author
There was a problem hiding this comment.
setupPostgresDatabase setup a 3 nodes DBaaS instance, so the standby host should not be empty
zliang-akamai
force-pushed
the
zhiwei/dbaas-hosts-update
branch
from
ac8a60c to
6452bcf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Update database host fields from "secondary" to "standby" to reflect the DBaaS API change.
✔️ How to Test