Conversation
vshanthe
requested review from
ezilber-akamai,
jriddle-linode and
zliang-akamai
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
Integration tests added for IAM role-permissions and entities endpoints, including tests for retrieving and updating user permissions, listing entities, and fetching entity roles.
- Tests for account and user role-permissions endpoints (GET, PUT)
- Tests for entities listing and entity roles retrieval
- Test fixtures with recorded HTTP interactions for all new test cases
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/integration/iam_roles_test.go | New test file with functions to test account role permissions, user role permissions (get/update), and user account permissions |
| test/integration/iam_entities_test.go | New test file with functions to test listing entities and retrieving entity roles |
| test/integration/fixtures/TestIAM_UpdateUserRolePermissions.yaml | Fixture recording HTTP interactions for updating user role permissions |
| test/integration/fixtures/TestIAM_ListEntities.yaml | Fixture recording HTTP interactions for listing entities |
| test/integration/fixtures/TestIAM_GetUserRolePermissions.yaml | Fixture recording HTTP interactions for getting user role permissions |
| test/integration/fixtures/TestIAM_GetUserAccountPermissions.yaml | Fixture recording HTTP interactions for getting user account permissions |
| test/integration/fixtures/TestIAM_GetEntityRoles.yaml | Fixture recording HTTP interactions for getting entity roles |
| test/integration/fixtures/TestIAM_GetAccountRolePermissions.yaml | Fixture recording HTTP interactions for getting account role permissions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ezilber-akamai
approved these changes
Jan 5, 2026
Contributor
ezilber-akamai
left a comment
ezilber-akamai
left a comment
There was a problem hiding this comment.
Tests are passing locally. Nice work!
jriddle-linode
approved these changes
Jan 12, 2026
Collaborator
jriddle-linode
left a comment
jriddle-linode
left a comment
There was a problem hiding this comment.
LGTM. Thank you!
zliang-akamai
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Added integration test for IAM
i.e /iam/users/{username}/role-permissions
✔️ How to Test
tag - iam_beta
make fixtures TEST_ARGS="-run TestIAM"
📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.