coreboot patches: replaced lib/jpeg patches for heap increase and alloc failure with upstreamed merged ones #1795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlaurion
force-pushed
the
remove_heap_increase_patch_and_config_changes
branch
from
b1fda3b to
cca34f1
Compare
tlaurion
changed the title
Collaborator
Author
|
@JonathonHall-Purism ping! :) |
Collaborator
tlaurion
force-pushed
the
remove_heap_increase_patch_and_config_changes
branch
from
cd0b43c to
3a07b09
Compare
Collaborator
Author
|
@JonathonHall-Purism sorry for the delay: roms built for 3a07b09 |
Collaborator
Author
|
@JonathonHall-Purism ping :) |
JonathonHall-Purism
approved these changes
Oct 29, 2024
Collaborator
JonathonHall-Purism
left a comment
JonathonHall-Purism
left a comment
There was a problem hiding this comment.
Tested Librem 14, works. LGTM 👍
Collaborator
Author
|
Review OptiPlex
Le mar. 29 oct. 2024, 16 h 00, JonathonHall-Purism ***@***.***>
a écrit :
… ***@***.**** approved this pull request.
Tested Librem 14, works. LGTM 👍
—
Reply to this email directly, view it on GitHub
<#1795 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGKBMQNQVRUCWVCDQ4OHI3Z57SMFAVCNFSM6AAAAABOB2EHECVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMBSHE2TKNRTGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
… failure. Add https://review.coreboot.org/c/coreboot/+/83895 Repro: rm patches/coreboot-24.02.01/0001* patches/coreboot-24.02.01/0002* git fetch https://review.coreboot.org/coreboot refs/changes/94/83894/2 && git format-patch -1 --stdout FETCH_HEAD > patches/coreboot-24.02.01/0001-vc_wuffs-upgrade-to-Wuffs_0.4.0-alpha.8.patch git fetch https://review.coreboot.org/coreboot refs/changes/95/83895/3 && git format-patch -1 --stdout FETCH_HEAD > patches/coreboot-24.02.01/0002-lib_jpeg-avoidcalling-malloc-and-free.patch sed -i 's/CONFIG_HEAP_SIZE=0x400000/CONFIG_HEAP_SIZE=0x100000/g' config/coreboot-* Signed-off-by: Thierry Laurion <insurgo@riseup.net>
Instead of requesting additional ramstage heap, cherry-pick patches for newer JPEG decoder that does not require heap allocation. Signed-off-by: Jonathon Hall <jonathon.hall@puri.sm> Signed-off-by: Thierry Laurion <insurgo@riseup.net>
…place Signed-off-by: Thierry Laurion <insurgo@riseup.net>
…e to fix CONFIG_HEAP_SIZE Did for TXT/non-TXT boards: docker run -e DISPLAY=$DISPLAY --network host --rm -ti -v $(pwd):$(pwd) -w $(pwd) tlaurion/heads-dev-env:latest -- make BOARD=optiplex-7010_9010*-hotp-maximized coreboot.modify_and_save_oldconfig_in_place Signed-off-by: Thierry Laurion <insurgo@riseup.net>
tlaurion
force-pushed
the
remove_heap_increase_patch_and_config_changes
branch
from
d271254 to
ccfb4c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream merged lib/jpeg chosen fixes, more elegant then increasing the HEAP_SIZE:
This replaces pending patches (Dasharo fork not needing HEAP_SIZE changes in configs in master since based on coreboot prior of https://review.coreboot.org/c/coreboot/+/78271 which introduced wuff for jpeg parser)
Repro:
@JonathonHall-Purism (Purism fork needs the change too)
Tested working under qemu.