Skip to content

Conversation

@tlaurion
Copy link
Collaborator

@tlaurion tlaurion commented Mar 3, 2025

So that we can show problem to upstream and blocker to #1908 per https://review.coreboot.org/c/coreboot/+/83274

akunterkontrolle and others added 30 commits February 11, 2025 11:25
Signed-off-by: Thierry Laurion <insurgo@riseup.net>
Signed-off-by: Thierry Laurion <insurgo@riseup.net>
Signed-off-by: Thierry Laurion <insurgo@riseup.net>
Signed-off-by: Thierry Laurion <insurgo@riseup.net>
Signed-off-by: Thierry Laurion <insurgo@riseup.net>
…for t480

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
Signed-off-by: Thierry Laurion <insurgo@riseup.net>
…ce its not sharing the same coreboot buildstack (something 25.X.X, need to check)

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
…ack, since its not sharing the same coreboot buildstack (something 25.X.X, need to check)"

This reverts commit b1f279354388fd8e71abd9f1514246d7e9f6ed1c.

Hmmm....

WGET="" bin/fetch_coreboot_crossgcc_archive.sh "/home/user/heads/build/x86/coreboot-t480" "binutils" "/home/user/heads/packages/x86"
--2025-02-11 14:46:38--  https://ftpmirror.gnu.org/binutils/binutils-2.43.1.tar.xz
Resolving ftpmirror.gnu.org (ftpmirror.gnu.org)... 209.51.188.200, 2001:470:142:5::200
Connecting to ftpmirror.gnu.org (ftpmirror.gnu.org)|209.51.188.200|:443... connected.
HTTP request sent, awaiting response... 302 Moved Temporarily
Location: https://mirror.csclub.uwaterloo.ca/gnu/binutils/binutils-2.43.1.tar.xz [following]
--2025-02-11 14:46:40--  https://mirror.csclub.uwaterloo.ca/gnu/binutils/binutils-2.43.1.tar.xz
Resolving mirror.csclub.uwaterloo.ca (mirror.csclub.uwaterloo.ca)... 129.97.134.71, 2620:101:f000:4901:c5c:0:f:1055
Connecting to mirror.csclub.uwaterloo.ca (mirror.csclub.uwaterloo.ca)|129.97.134.71|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 28174300 (27M) [text/plain]
Saving to: '/home/user/heads/packages/x86/coreboot-crossgcc-binutils-2.43.1.tar.xz.tmp'

/home/user/heads/packages/x86/coreboot-crossgcc-binu 100%[=====================================================================================================================>]  26.87M  8.88MB/s    in 3.0s

2025-02-11 14:46:44 (8.88 MB/s) - '/home/user/heads/packages/x86/coreboot-crossgcc-binutils-2.43.1.tar.xz.tmp' saved [28174300/28174300]

/home/user/heads/packages/x86/coreboot-crossgcc-binutils-2.43.1.tar.xz.tmp: OK
touch "/home/user/heads/build/x86/coreboot-t480/.heads-crossgcc-pkg-binutils"
WGET="" bin/fetch_coreboot_crossgcc_archive.sh "/home/user/heads/build/x86/coreboot-t480" "gcc" "/home/user/heads/packages/x86"
--2025-02-11 14:46:44--  https://ftpmirror.gnu.org/gcc/gcc-14.2.0/gcc-14.2.0.tar.xz
Resolving ftpmirror.gnu.org (ftpmirror.gnu.org)... 209.51.188.200, 2001:470:142:5::200
Connecting to ftpmirror.gnu.org (ftpmirror.gnu.org)|209.51.188.200|:443... connected.
HTTP request sent, awaiting response... 302 Moved Temporarily
Location: https://mirror2.evolution-host.com/gnu/gcc/gcc-14.2.0/gcc-14.2.0.tar.xz [following]
--2025-02-11 14:46:44--  https://mirror2.evolution-host.com/gnu/gcc/gcc-14.2.0/gcc-14.2.0.tar.xz
Resolving mirror2.evolution-host.com (mirror2.evolution-host.com)... 167.114.8.249, 2607:5300:60:450d:c259:13f4:6df0:1
Connecting to mirror2.evolution-host.com (mirror2.evolution-host.com)|167.114.8.249|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 92306460 (88M) [application/x-xz]
Saving to: '/home/user/heads/packages/x86/coreboot-crossgcc-gcc-14.2.0.tar.xz.tmp'

/home/user/heads/packages/x86/coreboot-crossgcc-gcc- 100%[=====================================================================================================================>]  88.03M  32.9MB/s    in 2.7s

2025-02-11 14:46:48 (32.9 MB/s) - '/home/user/heads/packages/x86/coreboot-crossgcc-gcc-14.2.0.tar.xz.tmp' saved [92306460/92306460]

/home/user/heads/packages/x86/coreboot-crossgcc-gcc-14.2.0.tar.xz.tmp: OK
touch "/home/user/heads/build/x86/coreboot-t480/.heads-crossgcc-pkg-gcc"
WGET="" bin/fetch_coreboot_crossgcc_archive.sh "/home/user/heads/build/x86/coreboot-t480" "nasm" "/home/user/heads/packages/x86"
--2025-02-11 14:46:48--  https://www.nasm.us/pub/nasm/releasebuilds/2.16.03/nasm-2.16.03.tar.bz2
Resolving www.nasm.us (www.nasm.us)... 198.137.202.136, 2607:7c80:54:3::136
Connecting to www.nasm.us (www.nasm.us)|198.137.202.136|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 1361988 (1.3M) [application/x-bzip2]
Saving to: '/home/user/heads/packages/x86/coreboot-crossgcc-nasm-2.16.03.tar.bz2.tmp'

/home/user/heads/packages/x86/coreboot-crossgcc-nasm 100%[=====================================================================================================================>]   1.30M  2.90MB/s    in 0.4s

2025-02-11 14:46:49 (2.90 MB/s) - '/home/user/heads/packages/x86/coreboot-crossgcc-nasm-2.16.03.tar.bz2.tmp' saved [1361988/1361988]

/home/user/heads/packages/x86/coreboot-crossgcc-nasm-2.16.03.tar.bz2.tmp: OK
touch "/home/user/heads/build/x86/coreboot-t480/.heads-crossgcc-pkg-nasm"
WGET="" bin/fetch_coreboot_crossgcc_archive.sh "/home/user/heads/build/x86/coreboot-t480" "iasl" "/home/user/heads/packages/x86"
--2025-02-11 14:46:49--  https://distfiles.macports.org/acpica/acpica-unix-20241212.tar.gz
Resolving distfiles.macports.org (distfiles.macports.org)... 151.101.138.132
Connecting to distfiles.macports.org (distfiles.macports.org)|151.101.138.132|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2025-02-11 14:46:50 ERROR 404: Not Found.

Failed to download https://distfiles.macports.org/acpica/acpica-unix-20241212.tar.gz
Try mirrors for coreboot-crossgcc-acpica-unix-20241212.tar.gz
--2025-02-11 14:46:50--  https://storage.puri.st/heads-packages/coreboot-crossgcc-acpica-unix-20241212.tar.gz
Resolving storage.puri.st (storage.puri.st)... 146.190.140.226
Connecting to storage.puri.st (storage.puri.st)|146.190.140.226|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2025-02-11 14:46:51 ERROR 404: Not Found.

Failed to download https://storage.puri.st/heads-packages/coreboot-crossgcc-acpica-unix-20241212.tar.gz
--2025-02-11 14:46:51--  https://storage.puri.sm/heads-packages/coreboot-crossgcc-acpica-unix-20241212.tar.gz
Resolving storage.puri.sm (storage.puri.sm)... 146.190.140.226
Connecting to storage.puri.sm (storage.puri.sm)|146.190.140.226|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2025-02-11 14:46:52 ERROR 404: Not Found.

Failed to download https://storage.puri.sm/heads-packages/coreboot-crossgcc-acpica-unix-20241212.tar.gz

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
…hon when used under nix docker

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
…ls blobs scripts

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
… as base

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
…onfig and config/coreboot-novacustom-nv4x_adl.config

Then saved back in oldconfig with ./docker_repro.sh make BOARD=t480-maximized coreboot.modify_and_save_oldconfig_in_place

Notes:
- Pr0 requirements don't stick, investigate
- real quick overview of config, just rying to get thing build here

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
…EURL to use one of libreboot web mirror

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
…ot 24.02 buildstack)

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
…les in tree as per http://web.archive.org/web/20250211155526/https://notgivenby.github.io/heads-wiki/t480-port/#coreboot-config-for-t480 : No joy building, but will dump progress for others to pickup

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
…ake first layer

Will fail at
Updating git submodules.
payloads/external/Makefile.mk:399: "Using host toolchain to build Linuxboot"
    GEN        build.h
    IFDTOOL    -p sklkbl -F t480-maximized/fmap-template.fmd ../../../blobs/t480/ifd_16
    HOSTCC     cbfstool/fmd_parser.o
    HOSTCC     cbfstool/fmd_scanner.o
make[1]: *** No rule to make target '../../../vendorfiles/kabylake/Fsp_M.fd', needed by 't480-maximized/coreboot.pre'.  Stop.
make[1]: *** Waiting for unfinished jobs....
File ../../../blobs/t480/ifd_16 is 4096 bytes
Wrote layout to t480-maximized/fmap-template.fmd

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
…iles exist

For repro:
- To remove all files created by patches (would error to help dev remove them manually)
  - echo "bogus" | tee build/x86/coreboot-t480/.canary
  - sudo rm -rf build/x86/coreboot-t480/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480*
  - sudo rm build/x86/libgpg-error-1.46/src/syscfg/lock-obj-pub.powerpc64le-unknown-linux-musl.h
- Remove all .canary files, outside of detected git forks to speedup local builds, rebuilding only new files with make magic
  - ./docker_repro.sh make BOARD=t480-maximized real.remove_canary_files-extract_patch_rebuild_what_changed
- Rebuild from sources: unpack archives/git clone, patch, build from source
  - ./docker_repro.sh make BOARD=t480-maximized

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
…ream PR0 patchset https://review.coreboot.org/c/coreboot/+/85278

Repro:
git fetch https://review.coreboot.org/coreboot refs/changes/78/85278/3 && git format-patch -1 --stdout FETCH_HEAD > patches/coreboot-t480/85278-post-skylake-pr0.patch

Unfortunately
Applying patch file : patches/coreboot-t480/85278-post-skylake-pr0.patch
Checking patch build/x86/coreboot-t480/src/soc/intel/alderlake/finalize.c...
Checking patch build/x86/coreboot-t480/src/soc/intel/cannonlake/finalize.c...
Checking patch build/x86/coreboot-t480/src/soc/intel/common/block/lpc/Makefile.mk...
Checking patch build/x86/coreboot-t480/src/soc/intel/common/block/smm/smihandler.c...
Checking patch build/x86/coreboot-t480/src/soc/intel/common/pch/include/intelpch/lockdown.h...
Checking patch build/x86/coreboot-t480/src/soc/intel/common/pch/lockdown/Kconfig...
Checking patch build/x86/coreboot-t480/src/soc/intel/common/pch/lockdown/Makefile.mk...
Checking patch build/x86/coreboot-t480/src/soc/intel/common/pch/lockdown/lockdown.c...
Checking patch build/x86/coreboot-t480/src/soc/intel/common/pch/lockdown/lockdown_lpc.c...
Checking patch build/x86/coreboot-t480/src/soc/intel/common/pch/lockdown/lockdown_spi.c...
Checking patch build/x86/coreboot-t480/src/soc/intel/denverton_ns/lpc.c...
Checking patch build/x86/coreboot-t480/src/soc/intel/elkhartlake/finalize.c...
Checking patch build/x86/coreboot-t480/src/soc/intel/jasperlake/finalize.c...
Checking patch build/x86/coreboot-t480/src/soc/intel/meteorlake/finalize.c...
Checking patch build/x86/coreboot-t480/src/soc/intel/pantherlake/finalize.c...
Checking patch build/x86/coreboot-t480/src/soc/intel/skylake/finalize.c...
Checking patch build/x86/coreboot-t480/src/soc/intel/tigerlake/finalize.c...
Checking patch build/x86/coreboot-t480/src/soc/intel/xeon_sp/finalize.c...
Checking patch build/x86/coreboot-t480/src/soc/intel/xeon_sp/lockdown.c...
error: while searching for:

static void lpc_lockdown_config(void)
{
	/* Set BIOS Interface Lock, BIOS Lock */
	lpc_set_bios_interface_lock_down();

	/* Only allow writes in SMM */
	if (CONFIG(BOOTMEDIA_SMM_BWP)) {
		lpc_set_eiss();
		lpc_enable_wp();
	}
	lpc_set_lock_enable();
}

void soc_lockdown_config(int chipset_lockdown)
{
	if (chipset_lockdown == CHIPSET_LOCKDOWN_FSP)
		return;

	lpc_lockdown_config();
	pmc_lockdown_config();
	sata_lockdown_config(chipset_lockdown);
	spi_lockdown_config(chipset_lockdown);

error: patch failed: build/x86/coreboot-t480/src/soc/intel/xeon_sp/lockdown.c:6
Applied patch build/x86/coreboot-t480/src/soc/intel/alderlake/finalize.c cleanly.
Applied patch build/x86/coreboot-t480/src/soc/intel/cannonlake/finalize.c cleanly.
Applied patch build/x86/coreboot-t480/src/soc/intel/common/block/lpc/Makefile.mk cleanly.
Applied patch build/x86/coreboot-t480/src/soc/intel/common/block/smm/smihandler.c cleanly.
Applied patch build/x86/coreboot-t480/src/soc/intel/common/pch/include/intelpch/lockdown.h cleanly.
Applied patch build/x86/coreboot-t480/src/soc/intel/common/pch/lockdown/Kconfig cleanly.
Applied patch build/x86/coreboot-t480/src/soc/intel/common/pch/lockdown/Makefile.mk cleanly.
Applied patch build/x86/coreboot-t480/src/soc/intel/common/pch/lockdown/lockdown.c cleanly.
Applied patch build/x86/coreboot-t480/src/soc/intel/common/pch/lockdown/lockdown_lpc.c cleanly.
Applied patch build/x86/coreboot-t480/src/soc/intel/common/pch/lockdown/lockdown_spi.c cleanly.
Applied patch build/x86/coreboot-t480/src/soc/intel/denverton_ns/lpc.c cleanly.
Applied patch build/x86/coreboot-t480/src/soc/intel/elkhartlake/finalize.c cleanly.
Applied patch build/x86/coreboot-t480/src/soc/intel/jasperlake/finalize.c cleanly.
Applied patch build/x86/coreboot-t480/src/soc/intel/meteorlake/finalize.c cleanly.
Applied patch build/x86/coreboot-t480/src/soc/intel/pantherlake/finalize.c cleanly.
Applied patch build/x86/coreboot-t480/src/soc/intel/skylake/finalize.c cleanly.
Applied patch build/x86/coreboot-t480/src/soc/intel/tigerlake/finalize.c cleanly.
Applied patch build/x86/coreboot-t480/src/soc/intel/xeon_sp/finalize.c cleanly.
Applying patch build/x86/coreboot-t480/src/soc/intel/xeon_sp/lockdown.c with 1 reject...
Rejected hunk #1.
make: *** [Makefile:570: /home/user/heads/build/x86/coreboot-t480/.canary] Error 1

Will have to edit patch

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
…we are not interested into which are conflicting against coreboot upstream commit 2f1e4e5e8515dd350cc9d68b48d32a5b6b02ae6a

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
…config

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
…herwise build error

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
… after kexec call to final OS. Otherwise, problem with coreboot config)

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
…d error

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
…add the CircleCI

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
Resolve conflicts, enable TPM2 support into board configs that was missing sorry
- remove blobs/kabylake/fetch_split_fsp.sh since unneeded if depending on full FSP from tree
  - removed fsp.fd files placed in blobs and references to it in @gaspar-ilom branch
  - removed blobs/kabylake/* altogether since unneeded
- remove patches/coreboot-24.02.01/* since we use another fork (currently modules/coreboot: t480, might be renamed to coreboot release to be reused later)
- t480 boards depend on targets/xx80_me_blobs.mk now, next commit will cleanup prior work artifacts not needed; @gaspar-ilom approach cleaner

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
…mpler/merged of @gaspar-ilom

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
…ose are not maximized boards. We have to draw the line somewhere.

- Reuse good tweeks from gaspar-ilom's provided config/coreboot-t480-maximized.config
- move config/coreboot-t480-maximized.config to config/coreboot-t480.config, delete config/coreboot-t480-maximized.config
- rename boards/t480-hotp-maximized -> boards/t480-hotp, boards/t480-maximized/t480-maximized -> boards/t480-maximized/t480
- Adapt CircleCI board naming accordingly

TODO:
- discuss need of thunderbold firmware presence in fw, that were part of @notgivenby prior work and now gone. Should it be brought back?
- Tweaks of config/coreboot-t480.config against prior commit, outside of blobs paths having change.

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
…m cleaner merged/adapted work from @gaspar-ilom

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
tlaurion and others added 22 commits February 24, 2025 12:11
Signed-off-by: Thierry Laurion <insurgo@riseup.net>
repro

user@heads-t480:~/heads/blobs/xx80$ git status
On branch poc_t480
nothing to commit, working tree clean
user@heads-t480:~/heads/blobs/xx80$ cat hashes.txt
d3af2dfbf128bcddfc8c5810a11478697312e5701668f719f80f3f6322db5642  gbe.bin
f2f6d5fb0a5e02964b494862032fd93f1f88e2febd9904b936083600645c7fdf  ifd.bin
1990b42df67ba70292f4f6e2660efb909917452dcb9bd4b65ea2f86402cfa16b  me.bin
user@heads-t480:~/heads/blobs/xx80$ cat hashes.txt | awk -F " " {'print $1'} | while read hash; grep $hash README; done
bash: syntax error near unexpected token `done'
user@heads-t480:~/heads/blobs/xx80$ cat hashes.txt | awk -F " " {'print $1'} | while read hash; do grep $hash README; done
f2f6d5fb0a5e02964b494862032fd93f1f88e2febd9904b936083600645c7fdf  ifd.bin
1990b42df67ba70292f4f6e2660efb909917452dcb9bd4b65ea2f86402cfa16b  me.bin
user@heads-t480:~/heads/blobs/xx80$ vim README
user@heads-t480:~/heads/blobs/xx80$ vim README
user@heads-t480:~/heads/blobs/xx80$ cat hashes.txt | awk -F " " {'print $1'} | while read hash; do grep $hash README; done
d3af2dfbf128bcddfc8c5810a11478697312e5701668f719f80f3f6322db5642  gbe.bin
f2f6d5fb0a5e02964b494862032fd93f1f88e2febd9904b936083600645c7fdf  ifd.bin
1990b42df67ba70292f4f6e2660efb909917452dcb9bd4b65ea2f86402cfa16b  me.bin
user@heads-t480:~/heads/blobs/xx80$ sha256sum -c hashes.txt
gbe.bin: OK
ifd.bin: OK
me.bin: OK
user@heads-t480:~/heads/blobs/xx80$ cat hashes.txt | awk -F " " {'print $1'} | while read hash; do grep $hash README; done
d3af2dfbf128bcddfc8c5810a11478697312e5701668f719f80f3f6322db5642  gbe.bin
f2f6d5fb0a5e02964b494862032fd93f1f88e2febd9904b936083600645c7fdf  ifd.bin
1990b42df67ba70292f4f6e2660efb909917452dcb9bd4b65ea2f86402cfa16b  me.bin
user@heads-t480:~/heads/blobs/xx80$ cat .gitignore
me.bin
user@heads-t480:~/heads/blobs/xx80$ git status

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
Signed-off-by: Thierry Laurion <insurgo@riseup.net>
…nd where they come from

remove duplicate hashes

add reference to info on tpm reset because people might not read everything

rename README to README.md as it is markdown

Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
Signed-off-by: Thierry Laurion <insurgo@riseup.net>
only print the battery manufacturer in case there is more than one battery, otherwise omit it

make the code more readable for non-bash developers

extract common functions

Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
Resolve conficts too

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
automatically move into board target dir

rename blob creation file for t480 to indicate that the tb.bin is also downloaded and created

Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
…lashing the thunderbolt spi externally

Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
…T480s.patch: do not comment inclusion of thermal.asl

Thanks to @nic3-14159 over coreboot matrix channel for the tip https://matrix.to/#/!EhaGFZyYcbyhdSgStq:matrix.org/$Rp7bFaRphrasUhnvNRrNvfYdzMgThMUUjQNswvg5CWo?via=matrix.org&via=tchncs.de&via=envs.net

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
Merge conflict resolved

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
…nit config blob) and resave coreboot config with coreboot.modify_and_save_oldconfig_in_place helper

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
…p_2412

Resolve conflicts for .circleci/config.yml

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
… libreboot

the blob created from the script prior to this change is not confirmed working

this blob is now confirmed working if following the instructions from libreboot https://libreboot.org/docs/install/t480.html#update-lenovo-firmware-first

Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
…need to fix thermal codepath: as of now its either other thinkpads or t480. Not good

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
…T480s.patch: re-comment thermal.asl to see all boards fail to build

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
…they are built in paralle to see them fail and where

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
@tlaurion tlaurion force-pushed the 2412_with_libreboot_patchset branch from dacc570 to db1d533 Compare March 3, 2025 19:26
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tlaurion Why do we keep the patches and this one in particular at all if we are already dropping the T480 from this PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nvm, I should probably left this in #1908

@tlaurion
Copy link
Collaborator Author

tlaurion commented Mar 9, 2025

Fixed by @gaspar-ilom under #1908 commit f765586

@tlaurion tlaurion closed this Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants