T480: fix the headphone jack

[gaspar-ilom]

Adds an unmerged patch from coreboot to fix the headphone jack for the 480.
See the details in the commit message in the patch upstream: https://review.coreboot.org/c/coreboot/+/90023

Without this patch the headphone jack is not automatically detect and cannot even be switched to when using pipewire but only with pulseaudio.

Test reports

• @gaspar-ilom @doritos4mlady @MattClifton76 @notgivenby @akunterkontrolle
  • Thanks for the report @gaspar-ilom T480: fix the headphone jack #2030 (comment)

[gaspar-ilom]

I have just tested this in an Ubuntu Live system. When plugging in headphones they are automatically selected and audio can be played. Not sure which other issues there were with the headphone jack.
Also, it works in Qubes now. I think it did not work at all in Qubes before, because manual switching did not fix the issue with pipewire but only with pulseaudio.

I rebased and force-pushed including a commit with updates for the documentation. Maybe this documentation should actually be maintained under heads-wiki to be more accessible for end users.

@tlaurion The jack issues are fixed and this can be merged unless something is missing.

Unless we want a second test report from @doritos4mlady @MattClifton76 @notgivenby @akunterkontrolle ?

[MattClifton76]

I have just tested this in an Ubuntu Live system. When plugging in headphones they are automatically selected and audio can be played. Not sure which other issues there were with the headphone jack.

Also, it works in Qubes now. I think it did not work at all in Qubes before, because manual switching did not fix the issue with pipewire but only with pulseaudio.

I rebased and force-pushed including a commit with updates for the documentation. Maybe this documentation should actually be maintained under heads-wiki to be more accessible for end users.

@tlaurion The jack issues are fixed and this can be merged unless something is missing.

Unless we want a second test report from @doritos4mlady @MattClifton76 @notgivenby @akunterkontrolle ?

If there's anymore testing that is needed I won't be able to help for a couple weeks, I'm away for work.

[tlaurion]

I rebased and force-pushed including a commit with updates for the documentation. Maybe this documentation should actually be maintained under heads-wiki to be more accessible for end users.

@gaspar-ilom what about documenting left known issues under the board configs?
Agreed that wiki should tell users to look at board configs for current commit status, otherwise I see disjunction between docs and code.

https://github.com/linuxboot/heads/blob/master/boards%2FEOL_t480-maximized%2FEOL_t480-maximized.config

Are there still left known issue for t480?
As of now, I see the t480s having headset jack issue still. Maybe we should document known issues instead?

Also, @gaspar-ilom if you could link this report to upstream and tell that it worked for you, that would be great

[tlaurion]

I rebased and force-pushed including a commit with updates for the documentation. Maybe this documentation should actually be maintained under heads-wiki to be more accessible for end users.

@gaspar-ilom what about documenting left known issues under the board configs? Agreed that wiki should tell users to look at board configs for current commit status, otherwise I see disjunction between docs and code.

https://github.com/linuxboot/heads/blob/master/boards%2FEOL_t480-maximized%2FEOL_t480-maximized.config

Are there still left known issue for t480? As of now, I see the t480s having headset jack issue still. Maybe we should document known issues instead?

Also, @gaspar-ilom if you could link this report to upstream and tell that it worked for you, that would be great

@gaspar-ilom https://github.com/linuxboot/heads/blob/master/BOARDS_AND_TESTERS.md:
Please see boards/BOARD_NAME/BOARD_NAME.config for HCL details.

Maybe that is a bit too hidden, as #692 OP which should be part of documentation on boards, their blob requirements evolution in time etc?

[gaspar-ilom]

@gaspar-ilom what about documenting left known issues under the board configs? Agreed that wiki should tell users to look at board configs for current commit status, otherwise I see disjunction between docs and code.

https://github.com/linuxboot/heads/blob/master/boards%2FEOL_t480-maximized%2FEOL_t480-maximized.config

@tlaurion my proposal would be to require all (maintained) boards under heads to have a markdown file per board in some dedicated doc/ directory that lists the current state of the board in an understandable way for heads end users. This should replace the README.md files under blobs/ and the documentation in the comment in the config. We can still keep documenting things in the config if its technical information meant for developers/ board testers but not for end users. Under blobs/ we should also only have technical information for devs.

From heads wiki Github CI we can pull that directory and include it when building the website. This would provide us with a way to maintain the board specific documentation here alongside the code and it would be easy to make sure everything is in sync during review, while it would allow us to list all available boards in the wiki and give some specific information on them. Should also include the state (EOL, (un-)tested, unmaintained) We could start by automatically creating the initial version from the board config and README.md files or just create a generic placeholder where no info is available for now.

What do you thinks about this idea? Is it worth the effort? If so we should continue the discussion under a dedicated issue.

Are there still left known issue for t480? As of now, I see the t480s having headset jack issue still. Maybe we should document known issues instead?

Those are minor as listed here https://doc.coreboot.org/mainboard/lenovo/t480.html#known-issues

• dgpu has some issues (but my board does not have one)
• some fn+f keys don't work properly. not sure which ones exactly. the ones I use frequently do work, though.

Also, @gaspar-ilom if you could link this report to upstream and tell that it worked for you, that would be great

Done: https://review.coreboot.org/c/coreboot/+/90023/comments/daf72534_69d477a4

@gaspar-ilom https://github.com/linuxboot/heads/blob/master/BOARDS_AND_TESTERS.md:
Please see boards/BOARD_NAME/BOARD_NAME.config for HCL details.

Maybe that is a bit too hidden, as #692 OP which should be part of documentation on boards, their blob requirements evolution in time etc?

I think that both are too hidden. As a non-technical user I would only look at the documentation in the wiki and I would hate it if there were multiple files at different locations in source code to gather all the important information from. So I guess we have room for improvement here.

Do you think this issue cannot be merged yet due to the documentation? I do not think that it makes things worse than they are currently in master?!

[tlaurion]

Nothing blocks here. I will approve and merge, while documentation issue (not sure of feasibility of cross projects for github page rendering...) would need to be discussed in seperate issue @gaspar-ilom

[tlaurion]

LGTM! Thanks @gaspar-ilom

[gaspar-ilom]

@tlaurion The change has been merged upstream as patchset 4. We use patchset 2, but there are only whitespace changes. So no need to touch this again: https://review.coreboot.org/c/coreboot/+/90023/2..4