[BUG] /usr/share/perl5/Smokeping/probes/SSH.pm includes rsa1

[c3c1]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

ERROR: output of '/usr/bin/ssh-keyscan -t dsa,rsa,rsa1 127.0.0.1' does not match (?^i:^# \S+ SSH-)

See;
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=946852

Expected Behavior

/usr/bin/ssh-keyscan -t rsa 127.0.0.1

127.0.0.1:22 SSH-2.0-OpenSSH_8.9p1 Ubuntu-3ubuntu0.1

127.0.0.1 ssh-rsa AAAA

Steps To Reproduce

Add to smokeping/config/Probes

• SSH

binary = /usr/bin/ssh-keyscan # mandatory
forks = 5
offset = 70%
step = 60
timeout = 10

The following variables can be overridden in each target section

keytype = dsa
pings = 4
port = 22

Environment

- OS:ubuntu 22.04
- How docker service was installed: apt install on GCP instance

CPU architecture

x86-64

Docker creation

cat docker-apps/smokeping/docker-compose.yaml 
---
version: "2.1"
services:
  smokeping:
    image: lscr.io/linuxserver/smokeping:latest
    container_name: smokeping
    environment:
      - PUID=1000
      - PGID=1000
      - TZ=America/Chicago
    volumes:
      - /etc/smokeping/config:/config
      - /etc/smokeping/data:/data
    ports:
      - 80:80
    restart: unless-stopped

Container logs

2023-01-26T23:47:58.564102867Z [migrations] started
2023-01-26T23:47:58.570869846Z [migrations] 01-nginx-site-confs-default: skipped
2023-01-26T23:47:58.570896772Z [migrations] done
2023-01-26T23:47:58.683363679Z usermod: no changes
2023-01-26T23:47:58.683647848Z 
2023-01-26T23:47:58.683661942Z -------------------------------------
2023-01-26T23:47:58.683678053Z           _         ()
2023-01-26T23:47:58.683684991Z          | |  ___   _    __
2023-01-26T23:47:58.683690671Z          | | / __| | |  /  \
2023-01-26T23:47:58.683695322Z          | | \__ \ | | | () |
2023-01-26T23:47:58.683699987Z          |_| |___/ |_|  \__/
2023-01-26T23:47:58.683704749Z 
2023-01-26T23:47:58.683709076Z 
2023-01-26T23:47:58.683713849Z Brought to you by linuxserver.io
2023-01-26T23:47:58.683718672Z -------------------------------------
2023-01-26T23:47:58.683794761Z 
2023-01-26T23:47:58.683803677Z To support LSIO projects visit:
2023-01-26T23:47:58.683810304Z https://www.linuxserver.io/donate/
2023-01-26T23:47:58.683816694Z -------------------------------------
2023-01-26T23:47:58.683821428Z GID/UID
2023-01-26T23:47:58.683825910Z -------------------------------------
2023-01-26T23:47:58.687508119Z 
2023-01-26T23:47:58.687542198Z User uid:    1000
2023-01-26T23:47:58.687548179Z User gid:    1000
2023-01-26T23:47:58.687554979Z -------------------------------------
2023-01-26T23:47:58.687560909Z 
2023-01-26T23:47:58.783734896Z using keys found in /config/keys
2023-01-26T23:47:58.997351750Z [custom-init] No custom files found, skipping...
2023-01-26T23:47:59.045813475Z [ls.io-init] done.
2023-01-26T23:47:59.758132536Z ### parsing dig output...OK
2023-01-26T23:48:00.014092710Z ### assuming you are using an tcpping copy reporting in milliseconds
2023-01-26T23:48:00.026343220Z ### assuming you are using an fping copy reporting in milliseconds
2023-01-26T23:48:00.033104408Z ERROR: output of '/usr/bin/ssh-keyscan -t dsa,rsa,rsa1 127.0.0.1' does not match (?^i:^# \S+ SSH-)
2023-01-26T23:48:00.033145726Z  at (eval 113) line 1.
2023-01-26T23:48:00.033151613Z

[github-actions]

Thanks for opening your first issue here! Be sure to follow the bug or feature issue templates!

[c3c1]

Looking further into this, not only is rsa1 not going to work, the test to 127.0.0.1 also fails.

/usr/share/perl5/vendor_perl/Smokeping/probes/SSH.pm

[ironicbadger]

Proposed changes here would be to fold in the commit from the linked thread?

We pull in the latest upstream in the Dockerfile. Would you be so kind as to submit a PR if you already know what you expect the fix to be?

[c3c1]

See jwigley/docker-smokeping-speedtest#24

[waja]

Is there a chance to get that fixed for this docker image?

ERROR: output of '/usr/bin/ssh-keyscan -t dsa,rsa,ecdsa 127.0.0.1' does not match (?^i:^# \S+ SSH-) at (eval 108) line 1.