Fix LockRecursionException when doing FindById#2488
Merged
JKamsker merged 5 commits intolitedb-org:masterfrom Jun 4, 2024
Merged
Fix LockRecursionException when doing FindById#2488JKamsker merged 5 commits intolitedb-org:masterfrom
JKamsker merged 5 commits intolitedb-org:masterfrom
Conversation
…ead lock when done reading
Collaborator
Author
|
Ok just found out it was already fixed by #2436 but this fix here has a easier git comparison and tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2471, #2435, #2483
Problem was, that the enumerator did not release the readlock when doing FindById. When the Checkpoint then tried to aquire a writelock, the semaphore threw an exception, because there was still a readlock pending.