Fix/2670 memoryextensions net10 followup#2710
Merged
JKamsker merged 3 commits intolitedb-org:devfrom Oct 7, 2025
LPEdwin:fix/2670-memoryextensions-net10-followup
Merged
Fix/2670 memoryextensions net10 followup#2710JKamsker merged 3 commits intolitedb-org:devfrom LPEdwin:fix/2670-memoryextensions-net10-followup
JKamsker merged 3 commits intolitedb-org:devfrom
LPEdwin:fix/2670-memoryextensions-net10-followup
Conversation
Collaborator
|
Thank you for pointing that out! Somehow that must have slipped through. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #2670.
The previous patch on
devaddressed part of the issue, but missed an additional case.No new test was added, since
LinqBsonExpression_Tests.Linq_Enumerableswas already failing under .NET 10 and now passes with this fix.The root cause:
Containscan be invoked with 3 parameters. When the element type does not implementIEquatable<T>, a default comparer (null) is passed as the third parameter. This scenario was not handled by the previous patch.Changes:
ContainsRefs #2670