Added support for ignored files and folders. See issue #17#19
Open
samacs wants to merge 2 commits intoliudng:masterfrom
Open
Added support for ignored files and folders. See issue #17#19samacs wants to merge 2 commits intoliudng:masterfrom
samacs wants to merge 2 commits intoliudng:masterfrom
Conversation
Owner
|
samacs, thank you for your submission. |
Author
|
Would you mind I add a .editorconfig file just for go code? I think that'd
be better for other contributors too. Thanks!
…On Thu, Mar 14, 2019, 19:05 liudng ***@***.*** wrote:
samacs, thank you for your submission.
please convert the 1 tab character with 4 spaces to indent the source code.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#19 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAC8jGlzgRienFDIFABqncS_L5EL1lqKks5vWvHogaJpZM4bzb4h>
.
|
Owner
|
Of course not. this is a good practice. |
Owner
|
sorry, my idea is to return to the version before 6ee2a10 and submit the merge request. The benefit of this is a clearer revision history. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just added
Ignoredfield to JSON configuration and theDogostruct to deal with ignored folders and files under the ignored folders.If the resource being checked is a folder it is just skipped from adding to the
Dogo.sourceDir. All subsequent files under that directory are also ignored.I think it would have been easier to use
map[string]stringfor theDogo.Ignoredfield to perform a 1:1 search but I think it's easier to write only an array of files/folders in the JSON file.