Skip to content

Conversation

@cloudwebrtc
Copy link
Contributor

No description provided.

@cloudwebrtc cloudwebrtc merged commit 219abf9 into main Dec 17, 2024
7 checks passed
@cloudwebrtc cloudwebrtc deleted the fix/deprecated-methods-00 branch December 17, 2024 02:07
@bcherry
Copy link
Contributor

bcherry commented Jan 23, 2025

@cloudwebrtc it looks like this new withValues method was added only in the most recent release of flutter 3.27.0, and this change makes the components lib incompatible with older versions. should we wait longer to introduce this change in the SDK?

@cloudwebrtc
Copy link
Contributor Author

The main reason is that CI will fail, saying we are using a deprecated API, xD.

info • 'withOpacity' is deprecated and shouldn't be used. Use .withValues() to avoid precision loss • lib/src/ui/widgets/track/audio_visualizer_widget.dart:172:47 • deprecated_member_use

@bcherry
Copy link
Contributor

bcherry commented Jan 25, 2025

@cloudwebrtc we should turn that off, failing CI on "info" seems too extreme... #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants