Support for JSON string in defaultImage field for overriding pipeline specific images in the mappings #293
Merged
rickstaa merged 12 commits intolivepeer:mainfrom Jan 28, 2025
Conversation
rickstaa
reviewed
Nov 30, 2024
rickstaa
force-pushed
the
update/ai-runner-image-flag-support
branch
from
08e0bf9 to
ddfb96b
Compare
This was referenced Dec 11, 2024
Merged
…line specific images in mappings
rickstaa
force-pushed
the
update/ai-runner-image-flag-support
branch
from
3e48a78 to
57b5ef7
Compare
This commit expands the test coverage to ensure more robust behavior and refactors the `overridePipelineImages` function to improve error handling and readability.
rickstaa
force-pushed
the
update/ai-runner-image-flag-support
branch
from
57b5ef7 to
aca9cc8
Compare
victorges
approved these changes
Jan 22, 2025
Contributor
victorges
left a comment
victorges
left a comment
There was a problem hiding this comment.
LGTM as it works, but I suggested some code changes. I'll open a separate branch to share with you to facilitate.
Contributor
|
@rickstaa here's a branch with my suggested changes: aca9cc8...vg/update/ai-runner-image-flag-support Keep in mind I only updated |
Member
Thanks will do! |
This commit ensures the tests are compatible with the new image overrides behavoir.
This commit enhances the worker tests by introducing cases to verify the behavior of image overrides.
victorges
approved these changes
Jan 23, 2025
rickstaa
added a commit
to RUFFY-369/go-livepeer
that referenced
this pull request
Jan 23, 2025
…des` This commit introduces deprecation logic for the `aiRunnerImage` flag, replacing it with a new `aiRunnerImageOverrides` flag. The new flag is designed to support enhanced image override functionality as implemented in the worker logic in [ai-worker PR livepeer#293](livepeer/ai-runner#293).
rickstaa
added a commit
to RUFFY-369/go-livepeer
that referenced
this pull request
Jan 27, 2025
…des` This commit introduces deprecation logic for the `aiRunnerImage` flag, replacing it with a new `aiRunnerImageOverrides` flag. The new flag is designed to support enhanced image override functionality as implemented in the worker logic in [ai-worker PR livepeer#293](livepeer/ai-runner#293).
rickstaa
added a commit
to RUFFY-369/go-livepeer
that referenced
this pull request
Jan 28, 2025
…des` This commit introduces deprecation logic for the `aiRunnerImage` flag, replacing it with a new `aiRunnerImageOverrides` flag. The new flag is designed to support enhanced image override functionality as implemented in the worker logic in [ai-worker PR livepeer#293](livepeer/ai-runner#293).
rickstaa
added a commit
to livepeer/go-livepeer
that referenced
this pull request
Jan 28, 2025
This commit introduces deprecation logic for the `aiRunnerImage` flag, replacing it with a new `aiRunnerImageOverrides` flag. The new flag is designed to support enhanced image override functionality as implemented in the worker logic in [ai-worker PR #293](livepeer/ai-runner#293). --------- Co-authored-by: Rick Staa <rick.staa@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards closing 'livepeer/bounties/#69
This PR adds support for processing JSON string in
defaultImageand specifies pipeline-specific images as key-value pairs with their mappings being updated to overridecontainerImage.go-livepeerPR which it supports is #3284cc @rickstaa