Skip to content

add Transcoding session ended log message #2685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjh1 merged 4 commits into from
Dec 14, 2022
Merged

add Transcoding session ended log message #2685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
575f1d0
adjust transcode loop timeout
mjh1 Dec 9, 2022
8a17010
add Transcoding session ended log message
mjh1 Dec 9, 2022
31b9215
make log message clearer
mjh1 Dec 12, 2022
d8d57c1
comments and changelog
mjh1 Dec 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG_PENDING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,6 @@

#### Orchestrator
- \#2639 Increase IdleTimeout for HTTP connections (@leszko)
- \#2685 Add a log message when sessions are closed by the Broadcaster. Increase transcode loop timeout (@mj1)

#### Transcoder
8 changes: 6 additions & 2 deletions core/orchestrator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@ import (

const maxSegmentChannels = 4

var transcodeLoopTimeout = 1 * time.Minute
// this is set to be higher than httpPushTimeout in server/mediaserver.go so that B has a chance to end the session
// based on httpPushTimeout before transcodeLoopTimeout is reached
var transcodeLoopTimeout = 70 * time.Second
Copy link
Copy Markdown
Contributor

@thomshutt thomshutt Dec 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the idea here that we were timing out at the same time as the broadcaster does and so timed out before we had a chance for the B to end the session?

Copy link
Copy Markdown
Member Author

@mjh1 mjh1 Dec 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's it yep

Copy link
Copy Markdown
Contributor

@cyberj0g cyberj0g Dec 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment that this timeout is set to be greater than B timeout? I'm not sure if we want to have it as tight as possible, +10 sec probably should work fine.


// Gives us more control of "timeout" / cancellation behavior during testing
var transcodeLoopContext = func() (context.Context, context.CancelFunc) {
Expand Down Expand Up @@ -991,7 +993,9 @@ func (rtm *RemoteTranscoderManager) selectTranscoder(sessionId string, caps *Cap

// ends transcoding session and releases resources
func (node *LivepeerNode) EndTranscodingSession(sessionId string) {
node.endTranscodingSession(sessionId, context.TODO())
logCtx := context.TODO()
clog.V(common.DEBUG).Infof(logCtx, "Transcoding session ended by the Broadcaster for sessionID=%v", sessionId)
node.endTranscodingSession(sessionId, logCtx)
}

func (node *RemoteTranscoderManager) EndTranscodingSession(sessionId string) {
Expand Down