Conversation
github-actions
bot
added
go
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3410 +/- ##
===================================================
- Coverage 32.13630% 32.10172% -0.03458%
===================================================
Files 147 147
Lines 40851 40895 +44
===================================================
Hits 13128 13128
- Misses 26947 26991 +44
Partials 776 776
Continue to review full report in Codecov by Sentry.
|
server/ai_http.go
Outdated
| "pipeline_id": "", | ||
| "orchestrator_info": map[string]interface{}{ | ||
| "address": h.orchestrator.Address().Hex(), | ||
| "url": h.orchestrator.ServiceURI().String(), |
There was a problem hiding this comment.
We need the githash of go-livepeer (O) to be propagated here as well -- similarly a githash for the ai-runner in the runner events.
There was a problem hiding this comment.
will add it in a separate PR
leszko
left a comment
leszko
left a comment
There was a problem hiding this comment.
Added one comment, other than that LGTM
|
|
||
| var event map[string]interface{} | ||
| if err := json.Unmarshal(body, &event); err != nil { | ||
| var eventWrapper struct { |
There was a problem hiding this comment.
I think the unit tests are failing because of this change. Please check.
4 participants
PR adds kafka events to trace events of the stream