Change binding host for docker containers from 0.0.0.0 to 127.0.0.1#3589
Merged
Change binding host for docker containers from 0.0.0.0 to 127.0.0.1#3589
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3589 +/- ##
===================================================
- Coverage 30.78169% 30.77731% -0.00438%
===================================================
Files 153 153
Lines 45696 45696
===================================================
- Hits 14066 14064 -2
- Misses 30811 30813 +2
Partials 819 819
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
70bcfb7 to
9aabaa7
Compare
victorges
approved these changes
May 23, 2025
Contributor
victorges
left a comment
There was a problem hiding this comment.
If it works, I agree. Make sure Prometheus etc also still work but I don't see why it wouldn't.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@pwilczynskiclearcode pointed out that we probably should not bind to 0.0.0.0.
@rickstaa @victorges @ad-astra-video is there any reason we would need `0.0.0.0? If not then I suggest changing it to localhost only.