Skip to content

Change binding host for docker containers from 0.0.0.0 to 127.0.0.1#3589

Merged
leszko merged 1 commit intomasterfrom
rafal/update-container-host
May 26, 2025
Merged

Change binding host for docker containers from 0.0.0.0 to 127.0.0.1#3589
leszko merged 1 commit intomasterfrom
rafal/update-container-host

Conversation

@leszko
Copy link
Contributor

@leszko leszko commented May 23, 2025

@pwilczynskiclearcode pointed out that we probably should not bind to 0.0.0.0.

@rickstaa @victorges @ad-astra-video is there any reason we would need `0.0.0.0? If not then I suggest changing it to localhost only.

@github-actions github-actions bot added go Pull requests that update Go code AI Issues and PR related to the AI-video branch. labels May 23, 2025
@codecov
Copy link

codecov bot commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.77731%. Comparing base (4be352d) to head (9aabaa7).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3589         +/-   ##
===================================================
- Coverage   30.78169%   30.77731%   -0.00438%     
===================================================
  Files            153         153                 
  Lines          45696       45696                 
===================================================
- Hits           14066       14064          -2     
- Misses         30811       30813          +2     
  Partials         819         819                 
Files with missing lines Coverage Δ
ai/worker/docker.go 76.19962% <100.00000%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4be352d...9aabaa7. Read the comment docs.

Files with missing lines Coverage Δ
ai/worker/docker.go 76.19962% <100.00000%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, I agree. Make sure Prometheus etc also still work but I don't see why it wouldn't.

@leszko leszko merged commit a9903aa into master May 26, 2025
18 checks passed
@leszko leszko deleted the rafal/update-container-host branch May 26, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Issues and PR related to the AI-video branch. go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants