Skip to content

BYOC: add simple include/exclude ability of Orchestrators in request#3634

Merged
ad-astra-video merged 5 commits intomasterfrom
av/byoc-add-include-exclude-orchs-param
Jul 21, 2025
Merged

BYOC: add simple include/exclude ability of Orchestrators in request#3634
ad-astra-video merged 5 commits intomasterfrom
av/byoc-add-include-exclude-orchs-param

Conversation

@ad-astra-video
Copy link
Collaborator

What does this pull request do? Explain your changes. (required)

Adds ability to send parameter in request to Gateway to include or exclude Orchestrators based on serviceAddr.

Add to parameters field of request as a json string (e.g. "parameters": JSON.stringify(parameters)):

{"orchestrators": {
      "exclude": [
              "https://orch1.url",
              "https://orch2.url",
              "https://orch3.url"
      ],
      "include": [
              "https://orch4.url",
              "https://orch5.url",
              "https://orch6.url
      ]
}

Specific updates (required)

  • add exclude/include parameters to getJobOrchestrators to enable client simple ability to direct request if preferred

How did you test each of these updates (required)

Does this pull request close any open issues?

Checklist:

@ad-astra-video ad-astra-video requested a review from pschroedl June 19, 2025 15:52
@github-actions github-actions bot added the go Pull requests that update Go code label Jun 19, 2025
@ad-astra-video ad-astra-video force-pushed the av/byoc-add-include-exclude-orchs-param branch from 33b090f to b74a9b0 Compare June 19, 2025 19:05
@codecov
Copy link

codecov bot commented Jun 19, 2025

Codecov Report

Attention: Patch coverage is 52.94118% with 8 lines in your changes missing coverage. Please review.

Project coverage is 31.86444%. Comparing base (f46377d) to head (48bcb69).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
server/job_rpc.go 52.94118% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3634         +/-   ##
===================================================
+ Coverage   31.76413%   31.86444%   +0.10031%     
===================================================
  Files            156         156                 
  Lines          47349       47360         +11     
===================================================
+ Hits           15040       15091         +51     
+ Misses         31428       31381         -47     
- Partials         881         888          +7     
Files with missing lines Coverage Δ
server/job_rpc.go 23.57724% <52.94118%> (+6.16548%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f46377d...48bcb69. Read the comment docs.

Files with missing lines Coverage Δ
server/job_rpc.go 23.57724% <52.94118%> (+6.16548%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@pschroedl pschroedl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@ad-astra-video ad-astra-video merged commit 876c743 into master Jul 21, 2025
22 of 26 checks passed
@ad-astra-video ad-astra-video deleted the av/byoc-add-include-exclude-orchs-param branch July 21, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants