BYOC: fix req timeout removing capability v2#3651
Merged
ad-astra-video merged 4 commits intomasterfrom Jul 21, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3651 +/- ##
===================================================
+ Coverage 31.76413% 31.85110% +0.08697%
===================================================
Files 156 156
Lines 47349 47361 +12
===================================================
+ Hits 15040 15085 +45
+ Misses 31428 31387 -41
- Partials 881 889 +8
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
pschroedl
approved these changes
Jul 17, 2025
Collaborator
pschroedl
left a comment
There was a problem hiding this comment.
I might consider keeping the original err != context.cancelled, but LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Fix # 2 to fix kicking an external capability when the request timed out.
Request timeouts are not always going to be fatal, plan to monitor and adjust as build out BYOC.
Specific updates (required)
How did you test each of these updates (required)
Does this pull request close any open issues?
Checklist:
makeruns successfully./test.shpass