Skip to content

BYOC: fix req timeout removing capability v2#3651

Merged
ad-astra-video merged 4 commits intomasterfrom
av/fix-kicking-ext-cap-on-timeout
Jul 21, 2025
Merged

BYOC: fix req timeout removing capability v2#3651
ad-astra-video merged 4 commits intomasterfrom
av/fix-kicking-ext-cap-on-timeout

Conversation

@ad-astra-video
Copy link
Collaborator

@ad-astra-video ad-astra-video commented Jun 26, 2025

What does this pull request do? Explain your changes. (required)

Fix # 2 to fix kicking an external capability when the request timed out.

Request timeouts are not always going to be fatal, plan to monitor and adjust as build out BYOC.

Specific updates (required)

How did you test each of these updates (required)

Does this pull request close any open issues?

Checklist:

@ad-astra-video ad-astra-video requested a review from pschroedl June 26, 2025 17:28
@github-actions github-actions bot added the go Pull requests that update Go code label Jun 26, 2025
@codecov
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 31.85110%. Comparing base (f46377d) to head (c48cdb4).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
server/job_rpc.go 0.00000% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3651         +/-   ##
===================================================
+ Coverage   31.76413%   31.85110%   +0.08697%     
===================================================
  Files            156         156                 
  Lines          47349       47361         +12     
===================================================
+ Hits           15040       15085         +45     
+ Misses         31428       31387         -41     
- Partials         881         889          +8     
Files with missing lines Coverage Δ
server/job_rpc.go 23.54988% <0.00000%> (+6.13812%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 876c743...c48cdb4. Read the comment docs.

Files with missing lines Coverage Δ
server/job_rpc.go 23.54988% <0.00000%> (+6.13812%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@pschroedl pschroedl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might consider keeping the original err != context.cancelled, but LGTM.

@ad-astra-video ad-astra-video merged commit bdec9b3 into master Jul 21, 2025
18 checks passed
@ad-astra-video ad-astra-video deleted the av/fix-kicking-ext-cap-on-timeout branch July 21, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants