Skip to content

Re-encode audio to AAC for non-local outputs.#3657

Merged
mjh1 merged 2 commits intomasterfrom
ja/rtmp-aac
Jun 30, 2025
Merged

Re-encode audio to AAC for non-local outputs.#3657
mjh1 merged 2 commits intomasterfrom
ja/rtmp-aac

Conversation

@j0sh
Copy link
Collaborator

@j0sh j0sh commented Jun 28, 2025

Output audio is in Opus for WebRTC, but re-encode to AAC for non-local RTMP outputs (studio, youtube, etc) because not everyone supports Opus-in-RTMP.

@j0sh j0sh requested review from mjh1, thomshutt and victorges June 28, 2025 05:48
@github-actions github-actions bot added docker Pull requests that update Docker code go Pull requests that update Go code AI Issues and PR related to the AI-video branch. labels Jun 28, 2025
@mjh1 mjh1 merged commit 1ed3022 into master Jun 30, 2025
15 of 16 checks passed
@mjh1 mjh1 deleted the ja/rtmp-aac branch June 30, 2025 08:54
@codecov
Copy link

codecov bot commented Jun 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 31.70303%. Comparing base (808f793) to head (ab18dee).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
server/ai_live_video.go 0.00000% 5 Missing ⚠️
server/ai_mediaserver.go 0.00000% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3657         +/-   ##
===================================================
- Coverage   31.70561%   31.70303%   -0.00258%     
===================================================
  Files            156         156                 
  Lines          47244       47251          +7     
===================================================
+ Hits           14979       14980          +1     
- Misses         31382       31388          +6     
  Partials         883         883                 
Files with missing lines Coverage Δ
server/ai_process.go 1.68067% <ø> (ø)
server/ai_mediaserver.go 4.71888% <0.00000%> (-0.01425%) ⬇️
server/ai_live_video.go 0.00000% <0.00000%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 808f793...ab18dee. Read the comment docs.

Files with missing lines Coverage Δ
server/ai_process.go 1.68067% <ø> (ø)
server/ai_mediaserver.go 4.71888% <0.00000%> (-0.01425%) ⬇️
server/ai_live_video.go 0.00000% <0.00000%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Issues and PR related to the AI-video branch. docker Pull requests that update Docker code go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants