Skip to content

ai/live: Set idle timeout.#3670

Merged
j0sh merged 2 commits intomasterfrom
ja/idle-timeout
Jul 15, 2025
Merged

ai/live: Set idle timeout.#3670
j0sh merged 2 commits intomasterfrom
ja/idle-timeout

Conversation

@j0sh
Copy link
Collaborator

@j0sh j0sh commented Jul 11, 2025

We are accumulating hundreds of TCP connections per orchestrator on the gateways, and not having an idle timeout is probably why.

The timeout is set to 90 seconds to match the behavior of golang's default HTTP client

We are accumulating hundreds of TCP connections per orchestrator
on the gateways, and not having a timeout here is probably why.
@github-actions github-actions bot added the go Pull requests that update Go code label Jul 11, 2025
@codecov
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.69886%. Comparing base (0a77ad0) to head (f43c518).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3670         +/-   ##
===================================================
+ Coverage   31.69242%   31.69886%   +0.00644%     
===================================================
  Files            156         156                 
  Lines          47311       47314          +3     
===================================================
+ Hits           14994       14998          +4     
+ Misses         31433       31432          -1     
  Partials         884         884                 
Files with missing lines Coverage Δ
server/segment_rpc.go 73.03989% <ø> (ø)
trickle/trickle_publisher.go 63.50711% <100.00000%> (+0.52634%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a77ad0...f43c518. Read the comment docs.

Files with missing lines Coverage Δ
server/segment_rpc.go 73.03989% <ø> (ø)
trickle/trickle_publisher.go 63.50711% <100.00000%> (+0.52634%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@j0sh j0sh marked this pull request as ready for review July 12, 2025 00:12
@j0sh
Copy link
Collaborator Author

j0sh commented Jul 12, 2025

Ready for review. The straggling connections I spotted were from trickle preconnects retrying due to my testing method of killing an active runner - see #3675 for the fix to that

@j0sh j0sh requested review from leszko, mjh1 and victorges July 12, 2025 00:55
Copy link
Contributor

@leszko leszko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@j0sh j0sh enabled auto-merge (squash) July 15, 2025 22:41
@j0sh j0sh merged commit 604827e into master Jul 15, 2025
16 of 18 checks passed
@j0sh j0sh deleted the ja/idle-timeout branch July 15, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants