Conversation
We are accumulating hundreds of TCP connections per orchestrator on the gateways, and not having a timeout here is probably why.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3670 +/- ##
===================================================
+ Coverage 31.69242% 31.69886% +0.00644%
===================================================
Files 156 156
Lines 47311 47314 +3
===================================================
+ Hits 14994 14998 +4
+ Misses 31433 31432 -1
Partials 884 884
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Collaborator
Author
|
Ready for review. The straggling connections I spotted were from trickle preconnects retrying due to my testing method of killing an active runner - see #3675 for the fix to that |
mjh1
approved these changes
Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are accumulating hundreds of TCP connections per orchestrator on the gateways, and not having an idle timeout is probably why.
The timeout is set to 90 seconds to match the behavior of golang's default HTTP client