Skip to content

ai: fix startup to allow 0 price on ai models#3674

Merged
ad-astra-video merged 2 commits intomasterfrom
av/allow-zero-price-models
Jul 21, 2025
Merged

ai: fix startup to allow 0 price on ai models#3674
ad-astra-video merged 2 commits intomasterfrom
av/allow-zero-price-models

Conversation

@ad-astra-video
Copy link
Collaborator

What does this pull request do? Explain your changes. (required)

Update model config parsing so price of 0 is allowed. Mainly geared toward helping testing with no deposit/reserve running a full Gateway and Orchestrator stack.

Specific updates (required)

  • Changed model config parsing to allow price of 0.

How did you test each of these updates (required)

Does this pull request close any open issues?

Checklist:

@ad-astra-video ad-astra-video requested a review from victorges July 11, 2025 15:09
@github-actions github-actions bot added the go Pull requests that update Go code label Jul 11, 2025
@codecov
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 31.97154%. Comparing base (e52c907) to head (882cc79).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cmd/livepeer/starter/starter.go 0.00000% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3674         +/-   ##
===================================================
- Coverage   31.97365%   31.97154%   -0.00211%     
===================================================
  Files            156         156                 
  Lines          47364       47364                 
===================================================
- Hits           15144       15143          -1     
- Misses         31326       31327          +1     
  Partials         894         894                 
Files with missing lines Coverage Δ
cmd/livepeer/starter/starter.go 7.28155% <0.00000%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e52c907...882cc79. Read the comment docs.

Files with missing lines Coverage Δ
cmd/livepeer/starter/starter.go 7.28155% <0.00000%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ad-astra-video ad-astra-video requested a review from eliteprox July 21, 2025 13:37
Copy link
Collaborator

@eliteprox eliteprox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, did not find any issues downstream with 0 price. We've been using this in testing for the past few weeks with no issues

@ad-astra-video ad-astra-video merged commit 7ce6ca5 into master Jul 21, 2025
18 checks passed
@ad-astra-video ad-astra-video deleted the av/allow-zero-price-models branch July 21, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants