Skip to content

Add pipeline (comfyui or streamdiffusion) to the ai_current_live_pipe…#3686

Merged
leszko merged 3 commits intomasterfrom
rafal/update-metrics
Jul 29, 2025
Merged

Add pipeline (comfyui or streamdiffusion) to the ai_current_live_pipe…#3686
leszko merged 3 commits intomasterfrom
rafal/update-metrics

Conversation

@leszko
Copy link
Contributor

@leszko leszko commented Jul 24, 2025

No description provided.

@github-actions github-actions bot added go Pull requests that update Go code AI Issues and PR related to the AI-video branch. labels Jul 24, 2025
@codecov
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

❌ Patch coverage is 3.22581% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 31.93001%. Comparing base (3a69e43) to head (53adca6).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
monitor/census.go 4.34783% 22 Missing ⚠️
server/ai_mediaserver.go 0.00000% 6 Missing ⚠️
server/ai_live_video.go 0.00000% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3686         +/-   ##
===================================================
- Coverage   31.94339%   31.93001%   -0.01338%     
===================================================
  Files            156         156                 
  Lines          47412       47435         +23     
===================================================
+ Hits           15145       15146          +1     
- Misses         31374       31396         +22     
  Partials         893         893                 
Files with missing lines Coverage Δ
core/livepeernode.go 60.22099% <ø> (ø)
server/ai_live_video.go 0.00000% <0.00000%> (ø)
server/ai_mediaserver.go 4.41315% <0.00000%> (-0.00830%) ⬇️
monitor/census.go 61.49635% <4.34783%> (-0.73409%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a69e43...53adca6. Read the comment docs.

Files with missing lines Coverage Δ
core/livepeernode.go 60.22099% <ø> (ø)
server/ai_live_video.go 0.00000% <0.00000%> (ø)
server/ai_mediaserver.go 4.41315% <0.00000%> (-0.00830%) ⬇️
monitor/census.go 61.49635% <4.34783%> (-0.73409%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

countByPipeline[v.Pipeline] = countByPipeline[v.Pipeline] + 1
streams = append(streams, k)
}
monitor.AICurrentLiveSessions(countByPipeline["comfyui"], "comfyui")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we just loop through the keys of countByPipeline rather than hard coding?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we could, but then I guess we would not zero the metric, because it would just not distinguish the empty map entry and no key. Or do you think it could work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjh1 I think I found a way to make it working for any pipeline. Please take a look:
cb113d5

@leszko leszko requested a review from mjh1 July 25, 2025 09:27
@leszko leszko marked this pull request as ready for review July 25, 2025 09:27
@leszko leszko merged commit e7f0ee1 into master Jul 29, 2025
18 checks passed
@leszko leszko deleted the rafal/update-metrics branch July 29, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Issues and PR related to the AI-video branch. go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants