Skip to content

Remove the session from the pool if the selection failed#3695

Merged
leszko merged 1 commit intomasterfrom
rafal/remove-session-if-selection-fails
Aug 4, 2025
Merged

Remove the session from the pool if the selection failed#3695
leszko merged 1 commit intomasterfrom
rafal/remove-session-if-selection-fails

Conversation

@leszko
Copy link
Contributor

@leszko leszko commented Aug 4, 2025

Related to this Discord thread.

Problem:

  • The Orch session is stored as inUse
  • But the Orch is busy
  • Then, we keep on retrying it instead of making the discovery again

Solution:
If the selection failed, then remove the session from the pool (it will anyway be added in the next 6 min, because we make discovery process every 6 min).

@leszko leszko requested a review from hjpotter92 August 4, 2025 12:56
@github-actions github-actions bot added go Pull requests that update Go code AI Issues and PR related to the AI-video branch. labels Aug 4, 2025
@codecov
Copy link

codecov bot commented Aug 4, 2025

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 31.92328%. Comparing base (fdebf7f) to head (41150dc).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
server/ai_process.go 0.00000% 4 Missing ⚠️
server/ai_session.go 0.00000% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3695         +/-   ##
===================================================
- Coverage   31.93229%   31.92328%   -0.00901%     
===================================================
  Files            156         156                 
  Lines          47441       47445          +4     
===================================================
- Hits           15149       15146          -3     
- Misses         31398       31404          +6     
- Partials         894         895          +1     
Files with missing lines Coverage Δ
server/ai_session.go 7.20930% <0.00000%> (ø)
server/ai_process.go 1.67504% <0.00000%> (-0.00563%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdebf7f...41150dc. Read the comment docs.

Files with missing lines Coverage Δ
server/ai_session.go 7.20930% <0.00000%> (ø)
server/ai_process.go 1.67504% <0.00000%> (-0.00563%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leszko leszko merged commit 36825da into master Aug 4, 2025
24 of 28 checks passed
@leszko leszko deleted the rafal/remove-session-if-selection-fails branch August 4, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Issues and PR related to the AI-video branch. go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants