Remove the session from the pool if the selection failed#3695
Merged
Conversation
hjpotter92
approved these changes
Aug 4, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3695 +/- ##
===================================================
- Coverage 31.93229% 31.92328% -0.00901%
===================================================
Files 156 156
Lines 47441 47445 +4
===================================================
- Hits 15149 15146 -3
- Misses 31398 31404 +6
- Partials 894 895 +1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to this Discord thread.
Problem:
inUseSolution:
If the selection failed, then remove the session from the pool (it will anyway be added in the next 6 min, because we make discovery process every 6 min).