cmd: move a few things to starter for easy embedding#3700
Merged
leszko merged 1 commit intolivepeer:masterfrom Aug 11, 2025
Merged
cmd: move a few things to starter for easy embedding#3700leszko merged 1 commit intolivepeer:masterfrom
leszko merged 1 commit intolivepeer:masterfrom
Conversation
7283839 to
fe2fe19
Compare
fe2fe19 to
772e21f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3700 +/- ##
===================================================
- Coverage 31.92117% 31.66336% -0.25781%
===================================================
Files 156 157 +1
Lines 47445 47446 +1
===================================================
- Hits 15145 15023 -122
- Misses 31405 31531 +126
+ Partials 895 892 -3
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Contributor
Author
|
@leszko Rebased and fixed the tests, thanks for review! The two GPU builds seem to be failing for this reason, which I recall being a recurring problem we had trouble tracking down: |
leszko
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Moves a bit of the node startup functionality from the
mainpackage into thestarterpackage to make it easier to boot up the node in an embedded way.How did you test each of these updates (required)
Node still boots up and runs afteward.
Does this pull request close any open issues?
streamplace/streamplace#69 🙃
Checklist:
makeruns successfully./test.shpass