Skip to content

ai/live: Send param updates to Kafka from the control handler.#3713

Merged
j0sh merged 3 commits intomasterfrom
ja/control-params-kafka
Aug 26, 2025
Merged

ai/live: Send param updates to Kafka from the control handler.#3713
j0sh merged 3 commits intomasterfrom
ja/control-params-kafka

Conversation

@j0sh
Copy link
Collaborator

@j0sh j0sh commented Aug 21, 2025

This mitigates some observability issues with param updates not being reported to Kafka since they were removed in [1].

[1] livepeer/ai-runner#723

The event fields were based on:

https://github.com/livepeer/ai-runner/blob/acff3a3be0c9235473ca69ed5fdc241e2af4a3b0/runner/app/live/streamer/process_guardian.py#L121-L132

and

event["stream_id"] = streamId
event["request_id"] = params.liveParams.requestID
event["pipeline_id"] = params.liveParams.pipelineID

This mitigates some observability issues with param updates not
being reported to Kafka since they were removed in [1].

[1] livepeer/ai-runner#723
@j0sh j0sh requested review from leszko, mjh1 and victorges August 21, 2025 23:52
@github-actions github-actions bot added go Pull requests that update Go code AI Issues and PR related to the AI-video branch. labels Aug 21, 2025
@j0sh j0sh requested a review from ecmulli August 21, 2025 23:53
@codecov
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

❌ Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 31.66474%. Comparing base (34e8e88) to head (515e965).
⚠️ Report is 172 commits behind head on master.

Files with missing lines Patch % Lines
server/ai_live_video.go 0.00000% 19 Missing ⚠️
server/ai_mediaserver.go 0.00000% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3713         +/-   ##
===================================================
- Coverage   31.68433%   31.66474%   -0.01959%     
===================================================
  Files            158         158                 
  Lines          47645       47665         +20     
===================================================
- Hits           15096       15093          -3     
- Misses         31654       31677         +23     
  Partials         895         895                 
Files with missing lines Coverage Δ
core/livepeernode.go 60.22099% <ø> (ø)
server/ai_mediaserver.go 4.65549% <0.00000%> (-0.01304%) ⬇️
server/ai_live_video.go 0.00000% <0.00000%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34e8e88...515e965. Read the comment docs.

Files with missing lines Coverage Δ
core/livepeernode.go 60.22099% <ø> (ø)
server/ai_mediaserver.go 4.65549% <0.00000%> (-0.01304%) ⬇️
server/ai_live_video.go 0.00000% <0.00000%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@j0sh j0sh enabled auto-merge (squash) August 26, 2025 16:35
@j0sh j0sh merged commit 366c540 into master Aug 26, 2025
15 of 16 checks passed
@j0sh j0sh deleted the ja/control-params-kafka branch August 26, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Issues and PR related to the AI-video branch. go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants