ai/live: Send param updates to Kafka from the control handler.#3713
Merged
ai/live: Send param updates to Kafka from the control handler.#3713
Conversation
This mitigates some observability issues with param updates not being reported to Kafka since they were removed in [1]. [1] livepeer/ai-runner#723
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3713 +/- ##
===================================================
- Coverage 31.68433% 31.66474% -0.01959%
===================================================
Files 158 158
Lines 47645 47665 +20
===================================================
- Hits 15096 15093 -3
- Misses 31654 31677 +23
Partials 895 895
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
leszko
approved these changes
Aug 22, 2025
mjh1
approved these changes
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mitigates some observability issues with param updates not being reported to Kafka since they were removed in [1].
[1] livepeer/ai-runner#723
The event fields were based on:
https://github.com/livepeer/ai-runner/blob/acff3a3be0c9235473ca69ed5fdc241e2af4a3b0/runner/app/live/streamer/process_guardian.py#L121-L132
and
go-livepeer/server/ai_live_video.go
Lines 689 to 691 in 1b6298d