Skip to content

Make debug segment count configurable#3714

Merged
mjh1 merged 2 commits intomasterfrom
mh/record-segs
Aug 27, 2025
Merged

Make debug segment count configurable#3714
mjh1 merged 2 commits intomasterfrom
mh/record-segs

Conversation

@mjh1
Copy link
Member

@mjh1 mjh1 commented Aug 22, 2025

I've been finding it necessary to save more than the first 10 segments to be able to debug the different input modes we have in the app. Make it configurable so we can easily adjust it temporarily.

@github-actions github-actions bot added go Pull requests that update Go code AI Issues and PR related to the AI-video branch. labels Aug 22, 2025
@mjh1 mjh1 requested a review from leszko August 22, 2025 10:57
@codecov
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 31.65527%. Comparing base (1b6298d) to head (f1cf907).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
server/mediaserver.go 0.00000% 2 Missing and 1 partial ⚠️
server/ai_live_video.go 0.00000% 2 Missing ⚠️
cmd/livepeer/starter/flags.go 0.00000% 1 Missing ⚠️
cmd/livepeer/starter/starter.go 0.00000% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3714         +/-   ##
===================================================
- Coverage   31.67174%   31.65527%   -0.01647%     
===================================================
  Files            158         158                 
  Lines          47645       47654          +9     
===================================================
- Hits           15090       15085          -5     
- Misses         31659       31671         +12     
- Partials         896         898          +2     
Files with missing lines Coverage Δ
core/livepeernode.go 60.22099% <ø> (ø)
cmd/livepeer/starter/flags.go 0.00000% <0.00000%> (ø)
cmd/livepeer/starter/starter.go 7.19424% <0.00000%> (-0.02163%) ⬇️
server/ai_live_video.go 0.00000% <0.00000%> (ø)
server/mediaserver.go 67.35004% <0.00000%> (-0.15377%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b6298d...f1cf907. Read the comment docs.

Files with missing lines Coverage Δ
core/livepeernode.go 60.22099% <ø> (ø)
cmd/livepeer/starter/flags.go 0.00000% <0.00000%> (ø)
cmd/livepeer/starter/starter.go 7.19424% <0.00000%> (-0.02163%) ⬇️
server/ai_live_video.go 0.00000% <0.00000%> (ø)
server/mediaserver.go 67.35004% <0.00000%> (-0.15377%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mjh1 mjh1 merged commit a81a755 into master Aug 27, 2025
17 of 18 checks passed
@mjh1 mjh1 deleted the mh/record-segs branch August 27, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Issues and PR related to the AI-video branch. go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants