Merged
Conversation
Needed to fix livepeer/lpms#438 The `go mod tidy` step reshuffled a few dependencies and cleaned up go.sum but no other version bumps.
github-actions
bot
added
the
dependencies
ad-astra-video
approved these changes
Sep 5, 2025
Collaborator
ad-astra-video
left a comment
ad-astra-video
left a comment
There was a problem hiding this comment.
Added myself as a reviewer reqeustd. Approved.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3734 +/- ##
===================================================
- Coverage 31.65564% 31.65288% -0.00276%
===================================================
Files 158 158
Lines 47764 47765 +1
===================================================
- Hits 15120 15119 -1
- Misses 31743 31744 +1
- Partials 901 902 +1 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Member
|
@j0sh builds, test pass, offchain manual stream tests succesfull. As a result, I would be comfortable shipping this. |
rickstaa
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed to fix livepeer/lpms#438
The
go mod tidystep reshuffled a few dependencies and cleaned up go.sum but no other version bumps.