Skip to content

fix: fix go fmt so tests can complete#3740

Merged
ad-astra-video merged 3 commits intomasterfrom
av/fix-go-fmt
Sep 17, 2025
Merged

fix: fix go fmt so tests can complete#3740
ad-astra-video merged 3 commits intomasterfrom
av/fix-go-fmt

Conversation

@ad-astra-video
Copy link
Collaborator

@ad-astra-video ad-astra-video commented Sep 16, 2025

What does this pull request do? Explain your changes. (required)

Fixed test suite action that is failing on go fmt step

Specific updates (required)

How did you test each of these updates (required)

Does this pull request close any open issues?

Checklist:

@github-actions github-actions bot added go Pull requests that update Go code AI Issues and PR related to the AI-video branch. labels Sep 16, 2025
@codecov
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 31.65498%. Comparing base (cb1fe6a) to head (360e18e).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3740         +/-   ##
===================================================
- Coverage   31.66126%   31.65498%   -0.00628%     
===================================================
  Files            158         158                 
  Lines          47765       47765                 
===================================================
- Hits           15123       15120          -3     
- Misses         31741       31744          +3     
  Partials         901         901                 
Files with missing lines Coverage Δ
ai/worker/docker.go 70.53571% <ø> (-0.17858%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d62ddc...360e18e. Read the comment docs.

Files with missing lines Coverage Δ
ai/worker/docker.go 70.53571% <ø> (-0.17858%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@j0sh
Copy link
Collaborator

j0sh commented Sep 16, 2025

cc @victorges since the slop broke it in #3738

we should make sure that tests pass before merging, and is it possible to have the cursor agent run gofmt after each change?


#### General

- [#3740](https://github.com/livepeer/go-livepeer/pull/3740) Fix go fmt issue (@ad-astra-video)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this isn't really necessary, it just fixes breakage introduced by the last PR

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed in 360e18e

@victorges
Copy link
Contributor

Yeah agree, sorry about that.

@ad-astra-video ad-astra-video marked this pull request as ready for review September 17, 2025 05:09
@ad-astra-video ad-astra-video merged commit 25a8dbb into master Sep 17, 2025
17 of 18 checks passed
@ad-astra-video ad-astra-video deleted the av/fix-go-fmt branch September 17, 2025 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Issues and PR related to the AI-video branch. go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants