Skip to content

worker: Allow runner to go back to LOADING post-start#3743

Merged
victorges merged 3 commits intomasterfrom
vg/feat/loading-overhaul
Sep 22, 2025
Merged

worker: Allow runner to go back to LOADING post-start#3743
victorges merged 3 commits intomasterfrom
vg/feat/loading-overhaul

Conversation

@victorges
Copy link
Contributor

What does this pull request do? Explain your changes. (required)
This is a change required by livepeer/ai-runner#798
so that the runner containers are "allowed" to go back to the LOADING state
after startup. This will be used to avoid sending streams to a container that
is still returning to the default params after handling a stream.

Specific updates (required)

  • Reset the loadingStartTime every time we see the LOADING state
  • thats all lol

How did you test each of these updates (required)
Ran the box and tested multiple loading scenarios, during stream, after stream, etc.

Does this pull request close any open issues?
Part of INF-297

Checklist:

@linear
Copy link

linear bot commented Sep 19, 2025

@github-actions github-actions bot added go Pull requests that update Go code AI Issues and PR related to the AI-video branch. labels Sep 19, 2025
@codecov
Copy link

codecov bot commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 31.94865%. Comparing base (d095d96) to head (78fd117).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3743         +/-   ##
===================================================
+ Coverage   31.94301%   31.94865%   +0.00564%     
===================================================
  Files            158         158                 
  Lines          47519       47520          +1     
===================================================
+ Hits           15179       15182          +3     
+ Misses         31437       31436          -1     
+ Partials         903         902          -1     
Files with missing lines Coverage Δ
ai/worker/docker.go 70.76649% <100.00000%> (+0.23078%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19ded51...78fd117. Read the comment docs.

Files with missing lines Coverage Δ
ai/worker/docker.go 70.76649% <100.00000%> (+0.23078%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@j0sh j0sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Josh Allmann <joshua.allmann@gmail.com>
@victorges victorges merged commit d8e520a into master Sep 22, 2025
12 of 13 checks passed
@victorges victorges deleted the vg/feat/loading-overhaul branch September 22, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Issues and PR related to the AI-video branch. go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants