Skip to content

refactor: use the built-in min to simplify the code#3750

Closed
quantpoet wants to merge 1 commit intolivepeer:masterfrom
quantpoet:master
Closed

refactor: use the built-in min to simplify the code#3750
quantpoet wants to merge 1 commit intolivepeer:masterfrom
quantpoet:master

Conversation

@quantpoet
Copy link

@quantpoet quantpoet commented Sep 24, 2025

What does this pull request do? Explain your changes. (required)

Use the built-in min to simplify the code

Inspired by #3577 and replace all.

Specific updates (required)

How did you test each of these updates (required)

Does this pull request close any open issues?

Checklist:

Signed-off-by: quantpoet <quantway@outlook.com>
@github-actions github-actions bot added the go Pull requests that update Go code label Sep 24, 2025
@quantpoet
Copy link
Author

@victorges @j0sh Hi, Could you please review this PR at your convenience? Thank you very much.

@j0sh
Copy link
Collaborator

j0sh commented Sep 26, 2025

Hey @quantpoet thanks for the PR, I am inclined to leave it as-is with the explicit if because the comment nested within that becomes inaccurate and potentially confusing otherwise. If there is a better way to reword or explain things then I'm happy to take another look.

@j0sh j0sh closed this Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants