refactor: replace context.WithCancel with t.Context#3786
Open
withtimezone wants to merge 1 commit intolivepeer:masterfrom
Open
refactor: replace context.WithCancel with t.Context#3786withtimezone wants to merge 1 commit intolivepeer:masterfrom
withtimezone wants to merge 1 commit intolivepeer:masterfrom
Conversation
Signed-off-by: withtimezone <with_timezone@outlook.com>
Author
|
@victorges Hi, Could you please review this PR at your convenience? Thank you very much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Optimize code using a more modern writing style. Official support from Go Team.
More info: golang/go#18368
Specific updates (required)
How did you test each of these updates (required)
Does this pull request close any open issues?
Checklist:
makeruns successfully./test.shpass