Conversation
Per the code: if the balance is already large enough to cover the required minimum credit (fee with ticket EV as the floor) then the code currently does not generate a ticket. Checking for this case prevents us from creating an empty-ticket payment. While those are not a huge problem for the orchestrators, it still leads to undesirable noise across the network.
Help out SDK implementers in case they miss this, since the errors are non-obvious: the orchestrator runs out of balance within a few minutes, even if payments are being sent regularly.
Compute the signature for test cases automatically if one was not provided as part of the test. Saves a bunch of boilerplate.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3870 +/- ##
===================================================
+ Coverage 32.53778% 32.55875% +0.02097%
===================================================
Files 170 170
Lines 41690 41700 +10
===================================================
+ Hits 13565 13577 +12
+ Misses 27103 27097 -6
- Partials 1022 1026 +4
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ai/live: Special-case zero NumTickets
Per the code: if the balance is already large enough to cover the
required minimum credit (fee with ticket EV as the floor) then
the code currently does not generate a ticket.
Checking for this case prevents us from creating an empty-ticket
payment. While those are not a huge problem for the orchestrators,
it still leads to undesirable noise across the network.
ai/live: Check for a required ManifestID
Help out SDK implementers in case they miss this, since the errors
are non-obvious: the orchestrator runs out of balance within a few
minutes, even if payments are being sent regularly.
ai/live: Simplify state in remote signer unit tests.
Compute the signature for test cases automatically if one was not
provided as part of the test. Saves a bunch of boilerplate.