Skip to content

Remove x11 from MacOS builds#3889

Merged
j0sh merged 4 commits intomasterfrom
ja/macos-x11
Apr 2, 2026
Merged

Remove x11 from MacOS builds#3889
j0sh merged 4 commits intomasterfrom
ja/macos-x11

Conversation

@j0sh
Copy link
Copy Markdown
Collaborator

@j0sh j0sh commented Apr 1, 2026

Somehow LPMS started pulling in x11 (maybe via CI runner update) and as a workaround we started dynamically linking x11 but this broke pre-built downloads in environments where x11 isn't available.

Fixed this correctly by disabling X11 builds in LPMS: livepeer/lpms#448 ; This PR updates the LPMS build to pull in the fixed ffmpeg.

@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Apr 1, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32.88876%. Comparing base (507a543) to head (4724412).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3889         +/-   ##
===================================================
+ Coverage   32.88638%   32.88876%   +0.00238%     
===================================================
  Files            171         171                 
  Lines          42063       42063                 
===================================================
+ Hits           13833       13834          +1     
+ Misses         27189       27183          -6     
- Partials        1041        1046          +5     

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 507a543...4724412. Read the comment docs.
see 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@j0sh j0sh marked this pull request as ready for review April 2, 2026 00:40
@seanhanca seanhanca self-requested a review April 2, 2026 00:42
@github-project-automation github-project-automation bot moved this from Triage to Ready to Merge in Engineering Roadmap Apr 2, 2026
@j0sh j0sh enabled auto-merge (squash) April 2, 2026 00:48
@j0sh j0sh merged commit 9e68815 into master Apr 2, 2026
18 checks passed
@j0sh j0sh deleted the ja/macos-x11 branch April 2, 2026 00:51
@github-project-automation github-project-automation bot moved this from Ready to Merge to Done in Engineering Roadmap Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants