Annotate --help flags with applicable node roles and warn on mismatches#3895
Open
Lazydayz137 wants to merge 2 commits intolivepeer:masterfrom
Open
Annotate --help flags with applicable node roles and warn on mismatches#3895Lazydayz137 wants to merge 2 commits intolivepeer:masterfrom
Lazydayz137 wants to merge 2 commits intolivepeer:masterfrom
Conversation
Add role annotations to all flag descriptions in --help output using the format [O]=Orchestrator, [B]=Gateway/Broadcaster, [T]=Transcoder, [W]=AI Worker, [ALL]=All roles. This makes it clear at a glance which flags are relevant for each node type. Also add runtime warning logic (WarnMismatchedFlags) that detects when a user sets a flag that doesn't apply to their selected role, logging a warning like: "Flag -maxTicketEV is intended for B roles but this node is running as orchestrator; it may have no effect" Fixes livepeer#2183 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Adds role annotations to all CLI flags and warns at startup when flags are set that do not apply to the selected node role.
Specific updates
How did you test each of these updates?
Does this pull request close any open issues?
Fixes #2183
Checklist