Conversation
Optionally add an auth callback to remote payment requests so operators can enforce policy checks before the remote signer sends down payments. When configured, the handler POSTs a JSON body containing the incoming request headers and the current signer state to the webhook URL right before encoding and signing. Configured auth headers are attached to the outbound request. Non-200 responses are propagated back to the caller through the existing API error envelope, preserving the upstream status code. New CLI flags: -remoteSignerWebhookUrl Webhook endpoint to call -remoteSignerWebhookHeaders Outbound auth headers (key:val,key2:val2) Omit -remoteSignerWebhookUrl to keep the existing behavior unchanged.
Allow the auth webhook to return an `expiry` field (Unix seconds) in its 200 response. The value is persisted in the signer's state and checked on subsequent requests. If the expiry hasn't yet passed, the webhook call is skipped. Once expired (or absent), auth resumes.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3897 +/- ##
===================================================
+ Coverage 32.87450% 33.21937% +0.34487%
===================================================
Files 171 171
Lines 42063 42117 +54
===================================================
+ Hits 13828 13991 +163
+ Misses 27194 27078 -116
- Partials 1041 1048 +7
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optionally add an auth callback to remote payment requests so operators
can enforce policy checks before the remote signer sends down payments.
When configured, the handler POSTs a JSON body containing the incoming
request headers and the current signer state to the webhook URL right
before encoding and signing. Configured auth headers are attached to the
outbound request. Non-200 responses are propagated back to the caller
through the existing API error envelope, preserving the upstream status
code.
Allow the auth webhook to return an
expiryfield (Unix seconds) inits 200 response. The value is persisted in the signer's state and
checked on subsequent requests. If the expiry hasn't yet passed, the
webhook call is skipped. Once expired (or absent), auth resumes.
New CLI flags:
-remoteSignerWebhookUrl Webhook endpoint to call
-remoteSignerWebhookHeaders Outbound auth headers (key:val,key2:val2)
Omit -remoteSignerWebhookUrl to keep the existing behavior unchanged.