Add Missing CLI Params to Adiak Metadata#647
Merged
rhornung67 merged 7 commits intodevelopfrom Feb 18, 2026
Merged
Conversation
m_num_z
m_num_zm_num_z
MrBurmark
reviewed
Feb 17, 2026
MrBurmark
reviewed
Feb 17, 2026
m_num_zm_num_z~
m_num_z~
rhornung67
approved these changes
Feb 18, 2026
MrBurmark
approved these changes
Feb 18, 2026
Member
|
@michaelmckinsey1 I restarted the failed CI jobs and now all checks are green. Feel free to merge this. |
Contributor
Author
|
@rhornung67 Thank you. GitHub is telling me I am "not authorized" to merge this, though. It is ready to merge on my end. |
Member
|
@michaelmckinsey1 you are correct. i set up the branch protection rules that way. i will merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a feature
It does the following (modify list as needed):
LTIMES.cppandsrc/common/Executor.cppChange the way zones is computed, such that the problem size you set on the command line will end up being the amount of unknowns (per-process). I did this so it is easier to compare against Kripke. I'm curious what @MrBurmark thinks; I do not know why the original expression is(target_size + (m_num_d * m_num_g)/2) / (m_num_d * m_num_g). If there is a specific reason, please let me know. I think it would be nice if we can simplify it.Introduce metadata specific to the LTIMES kernel.
LTIMES already has CLI-specific argumentsChanged this in favor of adding the CLI arguments to the metadata, as we do for other CLI arguments.--ltimes_num_m,--ltimes_num_g,--ltimes_num_d. This might be better implemented as just adding those to the metadata, and with the new definition of Z, it is easy to compute from the metadata after the runproblemsize/g/d. Total amount of unknowns is psilen orproblemsizeChange default values for LTimes to match an experimental configuration. 1M default problem size is fine.