Skip to content

Add Missing CLI Params to Adiak Metadata#647

Merged
rhornung67 merged 7 commits intodevelopfrom
ltimes-kernelmeta
Feb 18, 2026
Merged

Add Missing CLI Params to Adiak Metadata#647
rhornung67 merged 7 commits intodevelopfrom
ltimes-kernelmeta

Conversation

@michaelmckinsey1
Copy link
Contributor

@michaelmckinsey1 michaelmckinsey1 commented Feb 13, 2026

Summary

  • This PR is a feature

  • It does the following (modify list as needed):

    • Modifies LTIMES.cpp and src/common/Executor.cpp
    • Adds kernel-specific metadata at the request of @michaelmckinsey1
  • Change the way zones is computed, such that the problem size you set on the command line will end up being the amount of unknowns (per-process). I did this so it is easier to compare against Kripke. I'm curious what @MrBurmark thinks; I do not know why the original expression is (target_size + (m_num_d * m_num_g)/2) / (m_num_d * m_num_g). If there is a specific reason, please let me know. I think it would be nice if we can simplify it.

  • Introduce metadata specific to the LTIMES kernel. LTIMES already has CLI-specific arguments --ltimes_num_m, --ltimes_num_g, --ltimes_num_d. This might be better implemented as just adding those to the metadata, and with the new definition of Z, it is easy to compute from the metadata after the run Changed this in favor of adding the CLI arguments to the metadata, as we do for other CLI arguments.

    • Z can be computed from problemsize/g/d. Total amount of unknowns is psilen or problemsize
  • Change default values for LTimes to match an experimental configuration. 1M default problem size is fine.

@michaelmckinsey1 michaelmckinsey1 self-assigned this Feb 13, 2026
@michaelmckinsey1 michaelmckinsey1 changed the title Ltimes kernelmeta Add LTimes Metadata to Adiak and Change m_num_z Feb 13, 2026
@michaelmckinsey1 michaelmckinsey1 changed the title Add LTimes Metadata to Adiak and Change m_num_z Add Missing CLI Params to Adiak Metadata and Change m_num_z Feb 13, 2026
@michaelmckinsey1 michaelmckinsey1 marked this pull request as ready for review February 13, 2026 21:58
@michaelmckinsey1 michaelmckinsey1 changed the title Add Missing CLI Params to Adiak Metadata and Change m_num_z Add Missing CLI Params to Adiak Metadata and ~Change m_num_z~ Feb 17, 2026
@michaelmckinsey1 michaelmckinsey1 changed the title Add Missing CLI Params to Adiak Metadata and ~Change m_num_z~ Add Missing CLI Params to Adiak Metadata Feb 17, 2026
@rhornung67
Copy link
Member

@michaelmckinsey1 I restarted the failed CI jobs and now all checks are green. Feel free to merge this.

@michaelmckinsey1
Copy link
Contributor Author

@rhornung67 Thank you. GitHub is telling me I am "not authorized" to merge this, though. It is ready to merge on my end.

@rhornung67
Copy link
Member

@michaelmckinsey1 you are correct. i set up the branch protection rules that way. i will merge.

@rhornung67 rhornung67 merged commit 0ec52d0 into develop Feb 18, 2026
18 checks passed
@rhornung67 rhornung67 deleted the ltimes-kernelmeta branch February 18, 2026 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants