Skip to content

Slic's LoggerStream should not require an ostream in the constructor #521

@kennyweiss

Description

@kennyweiss

The ostream is only used by the root rank, but is required for all ranks.
We shouldn't need to create an ostream on ranks that it is not used.
This is especially problematic for fstreams.

@white238 has a WIP branch for this:

Possibilities to resolve this:

  • we can break this out into two constructors -- one that takes an ostream and one that does not,
  • we can allow a nullptr for the ostream instance, and modify the class to deal with a nullptr
  • we can remove the ostream from the constructor and add a function to set the ostream pointer.

Metadata

Metadata

Assignees

Labels

ReviewedSlicIssues related to Axom's 'slic' componentbugSomething isn't working

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions