Replace Array external buffer functionality with ArrayView#678
Merged
joshessman-llnl merged 19 commits intodevelopfrom Oct 27, 2021
Merged
Replace Array external buffer functionality with ArrayView#678joshessman-llnl merged 19 commits intodevelopfrom
joshessman-llnl merged 19 commits intodevelopfrom
Conversation
kennyweiss
reviewed
Oct 14, 2021
Member
kennyweiss
left a comment
There was a problem hiding this comment.
This is coming along really nicely @joshessman-llnl
Apologies if I jumped the gun a bit on this review, but I wanted to add some high-level design thoughts while you're working on this
| /// @} | ||
|
|
||
| /// \brief Swaps two ArrayBases | ||
| void swap(ArrayBase&) { } |
Member
There was a problem hiding this comment.
Is ArrayBase::swap() empty intentionally, or just not yet implemented?
Member
Author
There was a problem hiding this comment.
This is ArrayBase<T, 1> which has no member variables - in the general case though (implemented above) ArrayBase has m_dims and m_strides member variables that would need to be/are swapped.
white238
reviewed
Oct 21, 2021
white238
approved these changes
Oct 27, 2021
This was referenced Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
axom::ArrayArrayViewclass that wraps a pointer with indexing functionalityPossible follow-ups:
ArrayView- e.g.: