Skip to content

kripke changes#1236

Open
rfhaque wants to merge 5 commits intodevelopfrom
kripke_changes
Open

kripke changes#1236
rfhaque wants to merge 5 commits intodevelopfrom
kripke_changes

Conversation

@rfhaque
Copy link
Collaborator

@rfhaque rfhaque commented Feb 6, 2026

Description

This PR:

  1. Add the build option for building with single memory on MI300.
  1. Adds umpire device pool size input option to kripke/application.py
  2. Adds input parameters for the different scaling configurations to kripke/experiment.py

Adding/modifying a benchmark (docs: Adding a Benchmark)

  • If modifying the source code of a benchmark: create, self-assign, and link here a follow up issue with a link to the PR in the benchmark repo Umpire/CHAI changes  Kripke#70
  • If package.py upstreamed to Spack is insufficient, add/modify repo/benchmark_name/package.py plus: create, self-assign, and link here a follow up issue with a link to the PR in the Spack repo.
  • If application.py upstreamed to Ramble is insufficient, add/modify repo/benchmark_name/application.py plus: create, self-assign, and link here a follow up issue with a link to the PR in the Ramble repo.
  • Add/modify an experiments/benchmark_name/experiment.py to define an experiment

@github-actions github-actions bot added experiment New or modified experiment application labels Feb 6, 2026
@pearce8 pearce8 added this to the February 2026 milestone Feb 24, 2026
@pearce8 pearce8 added the changes requested Changes requested label Feb 24, 2026
Copy link
Collaborator

@pearce8 pearce8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kripke CI tests are failing on all systems, please diagnose/fix.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.30%. Comparing base (ad7d87e) to head (d3551d2).

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1236       +/-   ##
============================================
+ Coverage    46.99%   64.30%   +17.30%     
============================================
  Files           27       48       +21     
  Lines         1849     3664     +1815     
  Branches       285      285               
============================================
+ Hits           869     2356     +1487     
- Misses         920     1297      +377     
+ Partials        60       11       -49     

see 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

application changes requested Changes requested experiment New or modified experiment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants